-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extra maven parameters like files, classifiers, sources, javadoc #14
Comments
FYI - this commit seems to be working. Let me know if you are interested in a PR. |
Would be interested in something like this as well. It would be nice to upload the javadoc jar & sources alongside the artifact. |
I was inspired by your work. I need to add files with dynamically-created names; e.g., if I supply a glob pattern, I need it to expand out the name. I also wanted to make I'll be making a PR soon with the work I've done. Although I have things working locally, I don't have any bash-based tests to demonstrate it working. |
@aegershman Did you ever make the pull request to merge your work back here, to |
@mdb whew it's been an exciting 2 years since this PR lol. I don't fully recall everything about this, but yeah looks like there was this PR to pivotal-field-engineering, but I never moved the PR to be against this repo: vmware-archive#1 and it looks like someone else forked that repo and picked some of the commits into their master: Moneyfarm#2 To be honest I don't use the maven-resource anymore-- not that it isn't great software (built by awesome people). But now our company uses artifactory. We also found that we were using the maven-resource in the way we should've been using a collection of tasks. So, alas, I haven't used this resource in some time. But if the spirit moves you, you could cherry-pick the commits from one of the various forks listed above and open a PR to this repo with them 👍 |
Thanks for the thoughtful response, @aegershman. I may heed your suggestion and open a PR. However, in the intermediary, I'm also curious to hear more from you on this, if you're inspired to elaborate:
Thanks! |
Hey, thanks for the great resource. I was wondering if you had plans to support the other parameters available on mvn deploy:deploy-file.
My specific usecase is being able to upload the source files along with an artifact. Looks like this can be done by adding the parameters for files, classifiers and types as additional parameters.
Thanks again
The text was updated successfully, but these errors were encountered: