From ce13b44d5527a6141b65fd6456095255c7fa30f3 Mon Sep 17 00:00:00 2001 From: patrickcrocker Date: Tue, 3 Oct 2017 18:35:01 -0500 Subject: [PATCH] fixed incorrect SNAPSHOT version checking logic for check operation --- CHANGELOG.md | 9 +++++++-- assets/in | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 659df4b..9924cb0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,9 +4,14 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). -## [Unreleased] +## 1.3.4 - 2017-10-03 +### Fixed +- v1.3.3 introduced [Incorrect SNAPSHOT version checking logic](https://github.com/patrickcrocker/maven-resource/issues/12) for the `check` operation for snapshots but was quickly spotted by [@shinmyung0](https://github.com/shinmyung0). This is now fixed and the 1.3.3 release has been yanked! + +### Removed +- Version 1.3.3 (use 1.3.4 instead!!) -## 1.3.3 - 2017-10-03 +## 1.3.3 - 2017-10-03 [YANKED] ### Added - Change log file (CHANGELOG.md). - Generate release notes from CHANGELOG.me for github release (pipeline.yml). diff --git a/assets/in b/assets/in index bd524db..1327a49 100755 --- a/assets/in +++ b/assets/in @@ -86,7 +86,7 @@ fi # test for 1.0.0-SNAPSHOT and for 1.0.0-20170328.031519-19 isSnapshot=false -[[ "$version" = *-SNAPSHOT ]] && echo "$version" | grep -oEq "[0-9]{8}\.[0-9]{6}-[0-9]{1,}" && isSnapshot=true +[[ "$version" = *-SNAPSHOT ]] || echo "$version" | grep -oEq "[0-9]{8}\.[0-9]{6}-[0-9]{1,}" && isSnapshot=true url=$release_url [ -n "$snapshot_url" ] && [ "$isSnapshot" = true ] && url=$snapshot_url