Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingorable should fail fast on rails >= 5.1.6 with explanation #10

Open
eiked opened this issue Apr 11, 2018 · 0 comments
Open

ingorable should fail fast on rails >= 5.1.6 with explanation #10

eiked opened this issue Apr 11, 2018 · 0 comments

Comments

@eiked
Copy link

eiked commented Apr 11, 2018

Hi nthj,
Big thanks for the ingorable gem.
I found out, that this is now included since rails 5

It did still work with prior versions of rails 5
but since rails 5.1.6 it crashes rails (see below)

I'd like to suggest that the ignorable gem should be updated:

  • to fail fast when run on rails >= 5.1.6
  • to show a deprecation warning when run on rails 5 .. < 5.1.6

and give an explanation how to fix the problem,
aka how to migrate to the syntax in rails 5.

There is no good description in the rails docs, yet.
You might also want to update your readme.

This is how the bug shows up on crash:

ruby2.5/gems/2.5.0/gems/activerecord-5.1.6/lib/active_record/relation/query_methods.rb:1044:in build_select': undefined method any?' for nil:NilClass (NoMethodError)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant