Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly wrap context-related NeoFS Client errors #624

Open
AnnaShaleva opened this issue Sep 10, 2024 · 1 comment
Open

Properly wrap context-related NeoFS Client errors #624

AnnaShaleva opened this issue Sep 10, 2024 · 1 comment
Labels
enhancement Improving existing functionality I2 Regular impact S4 Routine U3 Regular

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm using NeoFS Client to perform object get and object search requests with cancellation context. If context is cancelled by the caller's code, the rpc error: code = Canceled desc = context canceled error is returned from this method:

func (x *ObjectListReader) Iterate(f func(oid.ID) bool) error {

This error is expected since context was explicitly cancelled. However, I can't identify this error with if errors.Is(err, context.Canceled) because it's not a wrapped error.

Describe the solution you'd like

context.Canceled and context.DeadlineExceeded should be recognizable by NeoFS client and should be returned as wrapped errors from all clients methods that work with context. We're at Go 1.22, multierror wrapping is supported.

Describe alternatives you've considered

Leave it as is, but it leads to the following code on the caller's side:

// isContextCanceledErr returns whether error is a wrapped [context.Canceled].
func isContextCanceledErr(err error) bool {
	return errors.Is(err, context.Canceled) ||
		strings.Contains(err.Error(), "context canceled")
}
@AnnaShaleva AnnaShaleva added enhancement Improving existing functionality U3 Regular S4 Routine I2 Regular impact labels Sep 10, 2024
@roman-khimov
Copy link
Member

But if it happens server-side it can be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I2 Regular impact S4 Routine U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants