Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate upload-bin and NeoFSBlockFetcher from SEARCH for range to SEARCH with strict equality comparator #3670

Open
AnnaShaleva opened this issue Nov 11, 2024 · 0 comments · May be fixed by #3691
Open

Migrate upload-bin and NeoFSBlockFetcher from SEARCH for range to SEARCH with strict equality comparator #3670

AnnaShaleva opened this issue Nov 11, 2024 · 0 comments · May be fixed by #3691
Assignees
@AliceInHunterland
Labels
enhancement Improving existing functionality I4 No visible changes S3 Minimally significant U1 Critically important to resolve quickly
Milestone
v0.107.0

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

SEARCH over range of objects (using matching.MatchNumGE and matching.MatchNumLT) often returns incomplete result (#3645). Search for a single object is more reliable.

Describe the solution you'd like

Use object.MatchStringEqual to search for 10K-batches for both upload-bin and NeoFSBlockFetcher.

Describe alternatives you've considered

No alternatives.
@AnnaShaleva AnnaShaleva added enhancement Improving existing functionality U1 Critically important to resolve quickly S3 Minimally significant I4 No visible changes labels Nov 11, 2024
@AnnaShaleva AnnaShaleva added this to the v0.107.0 milestone Nov 11, 2024
@AnnaShaleva AnnaShaleva mentioned this issue Nov 11, 2024
Open
AliceInHunterland added a commit that referenced this issue Nov 19, 2024
@AliceInHunterland
*: migrate to SEARCH with strict equality comparator
daf681b 
Depends on #3645. It should be
reverted once the issue is resolved.

Close #3670

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland AliceInHunterland linked a pull request Nov 19, 2024 that will close this issue
Open
AliceInHunterland added a commit that referenced this issue Nov 19, 2024
@AliceInHunterland
*: migrate to SEARCH with strict equality comparator
17e83e8 
Depends on #3645. It should be
reverted once the issue is resolved.

Close #3670

Signed-off-by: Ekaterina Pavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
enhancement Improving existing functionality I4 No visible changes S3 Minimally significant U1 Critically important to resolve quickly
Projects
None yet
Milestone
v0.107.0
Development

Successfully merging a pull request may close this issue.

upload-bin, NeoFSBlockFetcher: migrate to SEARCH with strict equality comparator nspcc-dev/neo-go
2 participants
@AnnaShaleva @AliceInHunterland