-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.1.0 breaks support for IE10/11 #15
Comments
Wow, that's an idiosyncrasy in old IE that I hadn't run into before. Are we cool with checking |
|
PRs welcome 👍 |
Here you go: #16 |
TehShrike
added a commit
that referenced
this issue
Nov 18, 2019
👍 merged. @yoshuawuyts can you publish as a patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am using is-dom through embed-js. I was wondering why it started to throw weird errors in IE and started digging deeper ...
Yarn silently updated my projects is-dom package from 1.0.9 to 1.1.0.
Following line causes the problem in IE:
is-dom/index.js
Line 5 in ebdf6a0
typeof window.Node !== 'function'
always returns true in IE (window.Node is of type 'object')My temporary workaround is to pin is-dom version to 1.0.9.
The text was updated successfully, but these errors were encountered: