Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Color Brightness #145

Closed
arcticicestudio opened this issue Mar 17, 2019 · 1 comment
Closed

Comment Color Brightness #145

arcticicestudio opened this issue Mar 17, 2019 · 1 comment
Labels
context-config context-syntax priority-high scope-ux type-improvement
Milestone
version-0.10.0

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Mar 17, 2019 •
edited
Loading

Bound to nordtheme/nord#94

This issue will implement the increase of the comment color (nord3) brightness by 10% from a lightness level of ~35% to ~45%.

➜ Please see nordtheme/nord#94 for all details about this design change decision.

⚠️ NOTE: This will also deprecate the comment contrast configuration because it is not necessary anymore for users to increase the brightness on their own.
A deprecation warning will be added to notify all users who have set a custom value for the g:nord_comment_brightness configuration variable.
@arcticicestudio arcticicestudio added this to the 0.10.0 milestone Mar 17, 2019
@arcticicestudio arcticicestudio self-assigned this Mar 17, 2019
@arcticicestudio arcticicestudio mentioned this issue Mar 17, 2019
Open
arcticicestudio added a commit that referenced this issue Mar 21, 2019
@arcticicestudio
Update copyright notices and contributor metadata
096ff7b 
GH-145
arcticicestudio added a commit that referenced this issue Mar 21, 2019
@arcticicestudio
Comment Color Brightness
def9d75 
-> Please see nordtheme/nord#94 for all
   details about this design change decision.

Increased the comment color (`nord3`) brightness by 10% from a lightness
level of ~35% to ~45%.

This change also deprecates the comment contrast (1) configuration.
It is not necessary anymore for users to increase the brightness on
their own when the default color has been increased by default.
A deprecation warning will be shown to notify all users who have set a
custom value for the `g:nord_comment_brightness` configuration variable.

References:
  (1)  https://github.com/arcticicestudio/nord-vim#comment-contrast

GH-145
@arcticicestudio arcticicestudio mentioned this issue Mar 21, 2019
Merged
arcticicestudio added a commit that referenced this issue Mar 21, 2019
@arcticicestudio
Merge pull request #146 from arcticicestudio/improvement/gh-145-comme…
9e0249c 
…nt-color-brightness

Comment Color Brightness
@arcticicestudio arcticicestudio removed their assignment Mar 21, 2019
@arcticicestudio
Copy link
Contributor Author

🚀 Deployed in release version 🏷 0.10.0

zx1986 added a commit to zx1986/xVim that referenced this issue Mar 31, 2019
@zx1986
fix: 移除 nord_comment_brightness 配置
ee5703a 
nordtheme/vim#145
@NathanielInman NathanielInman mentioned this issue May 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-config context-syntax priority-high scope-ux type-improvement
Projects
None yet
Milestone
version-0.10.0
Development

No branches or pull requests
1 participant
@arcticicestudio