Poor contrast between 'added block' background and comments in comparison view

[bluebartle]

When using the comparison view, the contrast between the 'added block' background colour and the comment colour makes reading the comments difficult (or at least, uncomfortable). This particular background colour makes reading anything at least a little uncomfortable, and I tend to select-all in order to avoid it, but I find it most difficult with comments.

Comments:

General:

[arcticicestudio]

Hi @ratskinmahoney 👋, thanks for your contribution 👍
This was a known problem some years ago and was improved in #25, but I can see that this might be a problem. I currently not sure if you're using the latest version of the theme plugin since the comment color was also improved in #42 (released with version 0.4.0), but the color on your screenshots looks not like the updated one.

1. Please make sure you're using the latest plugin version.
2. Please check if you're using a copy of the theme which gets automatically created by the IDE when a setting of the currently active editor or UI theme gets changed by the user. You can follow the instructions I've posted in Goland 2019.2.1 display wrong color for go code #100 (comment) which also solved the problem for the user.

I'll also test the diff view next time I push a PR. If this style is still used in the latest version, I think I'll port the improved styles implemented for the VS Code theme.

[bluebartle]

Thanks for the prompt and detailed reply, @arcticicestudio.

The version of the plugin I'm using is 0.8.1 - apologies for missing this information out in the initial report:

I've followed the instructions in the comment you linked above:

• Navigated to ~/Library/Preferences/<app>/colors/ (I'm on mac)
• Removed _@user_Nord.icls
• Started IntelliJ Idea
• In settings switched theme away from Nord, applied, and then switched the theme back to Nord and applied
  I've also tried uninstalling and reinstalling the plug-in, but with the same effect.

The colours still look the same, I'm afraid:

Here is what they look like normally:

PS: I'd be happy with the VS Code theme colours suggested. Cheers!

[nmaves]

I am still seeing this issue as well with 11.2

[arcticicestudio]

This is still a pending topic one a large list, but everyone can feel free to submit a PR using the linked PR from the VS Code port as reference. Unfortunately the proposal microsoft/vscode#71663 was closed/not accepted to improve the theme API within VS Code itself so I guess there's no other way around than adapting the adjusted styles from Nord Visual Studio Code.

[bluebartle]

Thanks for the update, @arcticicestudio.

Edit: Opened a PR and moved the comment to there: #159