Support for ediff

[Linuus]

It looks like there is no support for ediff yet.
Here's a list of faces that zenburn uses:
https://github.com/bbatsov/zenburn-emacs/blob/master/zenburn-theme.el#L524-L540

[arcticicestudio]

Hi @Linuus 👋, thanks for your contribution 👍
I've added it to the backlog, but anyone can feel free to submit a PR for it 😄

[ssnnoo]

Getting ediff to work with only 16 colours is a big challenge because the default ediff keeps the syntax highlighting and just overlays red etc. What could be done instead is to change the foreground to a constant color (also done in other themes, e.g. solarized) and highlight changes in bold. See attached screenshots. Any opinions regarding this?

[Linuus]

Personally I like the default style more I think. It's a bit easier for me to see what has changed, but maybe I would get used to the other style :)

What about using the default colors but make them a bit lighter/transparent and highlight the inline changes with regular Nord colors (so it more resembles the default ediff but it's a bit more Nord styleish)?

Also, just fixing that hard to read grey highlighting makes a huge difference! :)

[ssnnoo]

still there are occasions where the default colours do not provide great readability. but overall maybe a good compromise?

[ssnnoo]

or like this, but then again we lose the syntax highlighting in the active diff region. personally I don't mind as this is not super useful anyway.