Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aiohttp for the HTTP requests instead of requests #23

Open
ViktorBarzin opened this issue Jun 24, 2023 · 1 comment
Open

Use aiohttp for the HTTP requests instead of requests #23

ViktorBarzin opened this issue Jun 24, 2023 · 1 comment
Labels

Comments

@ViktorBarzin
Copy link

Is your feature request related to a problem? Please describe.
Nordigen client uses requests library which makes blocking http calls. This creates bottlenecks when fetching data for multiple requisition ids.

Describe the solution you'd like
Use aiohttp library which is asycnio-native. This will enable concurrent work using asyncio.gather which will dramatically speed up execution when working with multiple requistion ids.

The codebase is fairly small and I'm happy to make the change if the owners are happy with the idea.

@marcus302
Copy link

I would also be happy with this. If I implement this myself I'll share it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants