Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preview builds to PRs #12

Open
Robjam opened this issue Oct 6, 2019 · 1 comment
Open

Add preview builds to PRs #12

Robjam opened this issue Oct 6, 2019 · 1 comment
Assignees
@Robjam
Labels
enhancement New feature or request

Comments

@Robjam
Copy link
Contributor

Robjam commented Oct 6, 2019

For UI changes, there need to be a way to preview the changes of pull requests before deploying to the ‘master’ branch.

One idea is to link the repo to Netlify and trigger only on pull requests.

Requirements

  • These preview builds will need a different robots.txt to prevent indexing by search engines.
  • The endpoints must be accessible by smartphones to check responsiveness.

Any other feedback/proposals are welcome.
@Robjam Robjam self-assigned this Oct 6, 2019
@Robjam Robjam added the enhancement New feature or request label Oct 6, 2019
@peaceiris
Copy link

peaceiris commented Oct 7, 2019 •
edited
Loading

FYI.

Netlify deploy previews return X-Robots-Tag: noindex so we do not need robots.txt. Only a production branch needs robots.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Robjam Robjam

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Robjam @peaceiris