Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share application detection code with Mission Center? #424

Open
qwertychouskie opened this issue Dec 20, 2024 · 2 comments
Open

Share application detection code with Mission Center? #424

qwertychouskie opened this issue Dec 20, 2024 · 2 comments

Comments

@qwertychouskie
Copy link

When Mission Center rewrote the application detection code a few months ago, it was factored into a standalone crate that can be used by any application: https://gitlab.com/mission-center-devs/app-detection

Using this code would mean that application detection would be consistent between both applications, and any improvements to the shared code would benefit both applications. It might also fix some open app detection issues such as #380 and #402 and perhaps #362. This image was also recently posted in the Mission Center discord server comparing the app detection of Mission Center and Resources:

image

FWIW there are likely also other situations where Resources does better than Mission Center currently does, but ultimately it would be nice if the two projects shared the detection code.

@kicsyromy
Copy link

Just to chime in here, the crate is hosted in the mission-center-devs org, but I would be happy to move it to a neutral location, and change hosting providers if it makes things easier for both parties.

@nokyan
Copy link
Owner

nokyan commented Dec 21, 2024

Hi,
that sounds like a neat idea, I didn't know that Mission Center made app detection a standalone crate. If it fixes Resources' current app detection woes, even better.
It'd probably be a rather big undertaking though, I'll look into it once I've got some other features done.

Just to chime in here, the crate is hosted in the mission-center-devs org, but I would be happy to move it to a neutral location, and change hosting providers if it makes things easier for both parties.

I don't mind that at all, no worries. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants