forked from xai/autograde
-
Notifications
You must be signed in to change notification settings - Fork 0
/
autograde.py
executable file
·529 lines (432 loc) · 19.6 KB
/
autograde.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
#!/usr/bin/env python3
# -*- coding: utf-8 -*-
# vim:fenc=utf-8
import argparse
import json
import logging
import os
import re
import shutil
import tempfile
import coloredlogs
from nbgrader.apps import NbGraderAPI
from nbconvert import PythonExporter
from traitlets.config import get_config
import patoolib
"""
TODOs:
- check all return codes from nbgrader api calls
- deal with old metadata format of submitted notebooks
- source project config instead of implicitly setting stuff
"""
class Re(object):
def __init__(self):
self.last_match = None
def match(self, pattern, text):
self.last_match = re.match(pattern, text)
return self.last_match
def search(self, pattern, text):
self.last_match = re.search(pattern, text)
return self.last_match
class Validator:
def __init__(self, warn_only=False):
self.warn_only = warn_only
def validate(self, submission, notebook):
raise NotImplementedError
def is_warn_only(self):
return self.warn_only
class IllegalStuffValidator(Validator):
def __init__(self, warn_only=False):
super().__init__(warn_only)
def validate(self, submission, notebook):
violations = []
with open(notebook) as f:
json_notebook = json.load(f)
for index, cell in enumerate(json_notebook["cells"]):
if cell['cell_type'] != 'code':
continue # and hope for the best :-]
lineno = 0
for line in cell['source']:
lineno += 1
violation = None
if (line[0].strip() == "!"):
violation = "Shell command"
if (line[0].strip() == "%"):
violation = "Built-in magic command"
if violation:
e = ("validate(%s, %s):\n"
"\t%s found in cell %d, line %d:\n"
"\t> %s"
% (submission['number'], submission['assignment'],
violation, index, lineno, line.strip()))
violations.append(e)
return violations
class Collector:
def __init__(self, api, assignment, notebook_filename, datadir=["data"]):
self.api = api
self.assignment = assignment
self.notebook_filename = notebook_filename
self.datadir = datadir
self.dangerous_dir = "dangerous"
self.validators = []
self.interactive = False
def register_validator(self, validator):
if validator not in self.validators:
self.validators.append(validator)
def unregister_validator(self, validator):
if validator in self.validators:
self.validators.remove(validator)
def set_data_dir(self, datadir):
self.datadir = datadir
def set_dangerous_dir(self, dangerous_dir):
os.makedirs(dangerous_dir, exist_ok=True)
self.dangerous_dir = dangerous_dir
def set_interactive(self, interactive):
self.interactive = interactive
def set_common_prefix(self, cp):
self.common_prefix = cp
def collect_submissions(self, inputfile, target):
submissions = []
pattern_student_learn = (r"^(?P<number>[0-9]{8})_"
r"(?P<firstname>[^_]+)_"
r"(?P<lastname>[^_]+)_"
r"(?P<filename>.+)")
pattern_student_canvas = (r"^(?P<fullname>[^_]+)_"
r"(?P<x>[0-9]+)_"
r"(?P<y>[0-9]+)_"
r"(?P<courseid>[0-9]+)_"
r"(?P<asgmt>[^_]+)_"
r"(?P<number>[0-9]{8})")
pattern_group_learn = (r"^(?P<isgroup>Gruppe|Group) (?P<number>[0-9]+)_"
r"(?P<firstname>[^_]*)_?"
r"(?P<lastname>[^_]*)_"
r"(?P<filename>.+)")
filename, ext = os.path.splitext(inputfile)
basename = os.path.basename(inputfile)
errors = []
patterns = [pattern_student_learn, pattern_student_canvas, pattern_group_learn]
if (self.common_prefix is not None):
pattern_group_canvas = (fr"^(?P<isgroup>{self.common_prefix})(?P<number>[0-9]+)_"
r"(?P<x>[0-9]+)_"
r"(?P<y>[0-9]+)_"
r"(?P<courseid>[0-9]+)_"
r"(?P<asgmt>[^_]+)_"
r"(?P<number2>[0-9]{8})")
patterns.insert(0, pattern_group_canvas)
gre = Re()
if any(gre.match(regex_str, basename) for regex_str in patterns):
submission = {}
submission['assignment'] = self.assignment
submission['notebook'] = None
submission['datadir'] = None
if 'isgroup' not in gre.last_match.groupdict():
submission['type'] = 'student'
submission['number'] = gre.last_match.group('number')
else:
submission['type'] = 'group'
submission['number'] = 'group' + gre.last_match.group('number') + (f"_{gre.last_match.group('courseid')}" if 'courseid' in gre.last_match.groupdict() else '')
submission['dir'] = os.path.join(target, submission['number'],
self.assignment)
logging.info("%s submission found: %s" % (submission['type'],
basename))
files, suberrors = self.collect_files(inputfile, submission)
submissions.append(submission)
errors.extend(suberrors)
else:
if ext == '.ipynb':
e = ("Unmatched notebook found in %s" % inputfile)
errors.append(e)
logging.fatal(e)
elif ext in ['.zip', '.7z', '.tar.gz', 'tar.bz2', 'tar.xz']:
# look for submission inside archive
with tempfile.TemporaryDirectory() as tmpdir:
logging.info("Extracting %s to %s" % (inputfile, tmpdir))
for f in self.extract_zip(inputfile, tmpdir):
innersubs, innererrors = \
self.collect_submissions(f, target)
submissions.extend(innersubs)
errors.extend(innererrors)
else:
logging.fatal("Don't know what to do with file: %s" %
inputfile)
## raise NotImplementedError
return submissions, errors
def collect_files(self, inputfile, submission):
submission['invalid'] = False
filename, ext = os.path.splitext(inputfile)
files = []
errors = []
with tempfile.TemporaryDirectory() as tmpdir:
if os.path.isfile(filename) and ext == '.ipynb':
files.append(inputfile)
elif ext in ['.rar', '.zip', '.7z']:
files.extend(self.extract_zip(inputfile, tmpdir))
else:
raise NotImplementedError
for f in files:
fname, fext = os.path.splitext(f)
logging.debug("> %s" % f)
if fext == '.ipynb':
logging.debug("notebook found: %s" % f)
if not submission['notebook']:
submission['notebook'] = f
nbviolations = []
for validator in self.validators:
violations = validator.validate(submission, f)
if violations:
if validator.is_warn_only():
for e in violations:
logging.warn(e)
else:
submission['invalid'] = True
nbviolations.extend(violations)
if self.interactive and submission['invalid']:
print()
logging.warning("%d violation(s) found: " %
len(nbviolations))
for e in nbviolations:
logging.warning(e)
no = {'no', 'n'}
choice = input("Is this dangerous?\n"
"(this notebook will NOT "
"be executed for autograding "
"if you answer 'y') ")
if choice in no:
submission['invalid'] = False
nbviolations.clear()
errors.extend(nbviolations)
if submission['invalid']:
targetfile = os.path.join(self.dangerous_dir,
submission['number'] +
'-' +
self.notebook_filename)
else:
os.makedirs(submission['dir'], exist_ok=True)
targetfile = os.path.join(submission['dir'],
self.notebook_filename)
shutil.copyfile(f, targetfile)
else:
e = ("collect_files %s: %s" %
(submission['number'],
"Multiple notebooks found in submission!"))
if e not in errors:
errors.append(e)
elif os.path.isdir(f) and \
os.path.basename(f).lower() in self.datadir:
if not submission['datadir']:
logging.debug("Data dir found: %s" %
os.path.basename(f))
submission['datadir'] = f
data_target_dir = os.path.join(submission['dir'],
os.path.basename(f))
os.makedirs(submission['dir'], exist_ok=True)
# copy with overwriting
if os.path.exists(data_target_dir):
logging.warning("Overwriting target %s with %s" %
(data_target_dir, f))
shutil.rmtree(data_target_dir)
shutil.copytree(f, data_target_dir)
else:
e = ("collect_files %s: %s" %
(submission['number'],
"Multiple data dirs found in submission!"))
if e not in errors:
errors.append(e)
if not submission['notebook']:
e = "No notebook found in submission!"
errors.append("collect_files %s: %s" % (submission['number'],
e))
return files, errors
def filterAndPrune(self, root, items):
index = 0
length = len(items)
while index < length:
i = items[index]
if i.startswith('__MACOSX') or i.startswith('.'):
del items[index]
path = os.path.join(root, i)
if os.path.isdir(path):
shutil.rmtree(path)
elif os.path.isfile(path):
os.remove(path)
else:
logging.warning('Error while pruning: unexpected path %s'
% path)
length -= 1
else:
index += 1
def extract_zip(self, inputfile, target):
patoolib.extract_archive(inputfile, outdir=target)
extracted = []
for root, dirs, files in os.walk(target, topdown=True):
self.filterAndPrune(root, dirs)
self.filterAndPrune(root, files)
for f in files:
extracted.append(os.path.join(root, f))
for d in dirs:
extracted.append(os.path.join(root, d))
return extracted
def generate_feedback(self, student, force):
self.api.generate_feedback(self.assignment, student, force=force)
self.api.release_feedback(self.assignment, student)
def collect_feedback(self, student, output):
self.generate_feedback(student, True)
feedbackdir = 'feedback'
html = os.path.join(feedbackdir, student, self.assignment,
os.path.splitext(self.notebook_filename)[0] +
'.html')
if os.path.exists(html):
target = os.path.join(output, student + '.html')
logging.info("Collecting feedback from: %s" % html)
shutil.copy(html, target)
return 1
return 0
def get_notebook_name(api, assignment):
notebooks = api.get_notebooks(assignment)
if not notebooks:
return None
return notebooks[0]['name'] + ".ipynb"
def setup():
# TODO: Can one traverse `jupyter --paths` to pick up the config file?
c = None
my_glob = {'c': c, 'get_config': get_config}
exec(compile(open('nbgrader_config.py', "rb").read(), 'nbgrader_config.py',
'exec'), my_glob)
return NbGraderAPI(config=my_glob['c'])
def validate(api, assignment, submissions, target):
errors = []
exporter = PythonExporter()
for submission in submissions:
if submission['invalid']:
continue
student = submission['number']
## 1) convert submissions to py
print(submission['notebook'])
script, _ = exporter.from_filename(os.path.join(submission['dir'], os.path.basename(submission['notebook'])))
with open(os.path.join(target, student + '.py'), 'w') as f:
f.write(script)
## 2) create base:
release_dir = os.path.join(api.coursedir.release_directory, assignment)
jplag_base_dir = os.path.join(target, "base")
os.makedirs(jplag_base_dir, exist_ok=True)
print(release_dir)
## 2a) get release version of notebooks
for rf in [os.path.join(release_dir, f) for f in os.listdir(release_dir) if f.endswith('.ipynb')]:
script, _ = exporter.from_filename(rf)
with open(os.path.join(jplag_base_dir, os.path.splitext(os.path.basename(rf))[0] + '.py'), 'w') as o:
o.write(script)
## 3) call JPlag
if not True:
logging.fatal()
errors.append("validate(): Errors from JPlag (...)")
return "done", errors
def autograde(api, assignment, submissions, force):
errors = []
for submission in submissions:
if submission['invalid']:
continue
student = submission['number']
result = api.autograde(assignment, student, force=force)
if not result['success']:
logging.fatal(result['log'])
errors.append("autograde(%s, %s): Errors from nbgrader (scroll up)"
% (student, assignment))
return api.get_autograded_students(assignment), errors
def formgrade():
print()
logging.warning("Formgrading must be done manually in a jupyter instance!")
logging.warning("Run `jupyter notebook --no-browser` and grade manually.")
input("Press Enter to continue when you are done formgrading\n"
"or Ctrl-c to abort without generating feedback...")
def main():
coloredlogs.install(fmt='%(levelname)s %(message)s')
coloredlogs.set_level(logging.INFO)
parser = argparse.ArgumentParser()
parser.add_argument('-a', '--assignment',
help='Name of the assignment',
type=str,
required=True)
parser.add_argument('--dangerous',
help='Ignore validation warnings',
action="store_true")
parser.add_argument('-i', '--interactive',
help='Pass --interactive to halt on validation errors',
action="store_true")
parser.add_argument('-f', '--force',
help='Pass --force to nbgrader autograde',
action="store_true")
parser.add_argument('-n', '--noop',
help='Do not run autograde and feedback',
action="store_true")
parser.add_argument('-o', '--output',
help='Output directory for html feedback',
type=str,
default='upload')
parser.add_argument('-cp', '--commonprefix',
help='Common prefix for (Canvas) group submissions',
type=str)
parser.add_argument('inputfiles', default=[], nargs='+')
args = parser.parse_args()
assignment = args.assignment
output = os.path.join(args.output, assignment)
api = setup()
submissiondir = api.coursedir.submitted_directory
notebook_filename = get_notebook_name(api, assignment)
collectonly = args.noop
if args.dangerous and args.interactive:
logging.fatal("--dangerous and --interactive are mutually exclusive")
raise RuntimeError
if not notebook_filename:
logging.fatal("No source notebooks found for assignment: %s" %
assignment)
raise RuntimeError
collector = Collector(api, assignment, notebook_filename)
collector.set_data_dir(["data", "daten"])
collector.set_dangerous_dir("dangerous")
collector.set_interactive(args.interactive)
collector.set_common_prefix(args.commonprefix)
collector.register_validator(IllegalStuffValidator(args.dangerous))
submissions = []
errors = []
for inputfile in args.inputfiles:
inputsubmissions, inputerrors = \
collector.collect_submissions(inputfile, submissiondir)
errors.extend(inputerrors)
if inputsubmissions:
submissions.extend(inputsubmissions)
logging.info("Found %i submissions in %s." %
(len(inputsubmissions), inputfile))
else:
logging.fatal("No submissions found in %s." % inputfile)
logging.info("Found a total of %i submissions." % len(submissions))
if args.interactive:
no = {'no', 'n'}
choice = input("Continue with auto-grading? "
"(all valid notebooks will be executed) ")
if choice in no:
collectonly = True
## JPlag integration
jplag_dir = os.path.join("jplag", assignment)
os.makedirs(jplag_dir, exist_ok=True)
validate(api, assignment, submissions, jplag_dir)
if collectonly:
logging.info("autograding was disabled, exiting")
exit(0)
autograded, autograde_errors = autograde(api, assignment, submissions,
args.force)
errors.extend(autograde_errors)
logging.info("%d submissions have been autograded" % len(autograded))
if errors:
logging.fatal("There were %d fatal errors during autograding:" %
len(errors))
for i, e in enumerate(errors):
logging.fatal("[%d] %s" % (i, e))
formgrade()
os.makedirs(output, exist_ok=True)
reports = 0
for student in autograded:
logging.info("Collecting feedback for " + student)
reports += collector.collect_feedback(student, output)
logging.info("%d reports written to %s" % (reports, output))
if __name__ == "__main__":
main()