Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link URLs break forked repos #5

Open
thisisparker opened this issue Jan 7, 2023 · 2 comments
Open

Link URLs break forked repos #5

thisisparker opened this issue Jan 7, 2023 · 2 comments

Comments

@thisisparker
Copy link

This may be a non-goal of this (excellent) project, but for documentation's sake: the use of URLs relative to the root directory for the CSS and JS files break any fork that is not serving from the root directory. By default with Github, a fork of this repo would live at USERNAME.github.io/njyoon.github.io, and those links will look for e.g. the javascript files at USERNAME.github.io/js/ instead of USERNAME.github.io/njyoon.github.io/js/.

The quick fix I found is removing the leading slash from the src attributes in index.html, nyt.html, and pdf.html. I don't know if there are other knock-on effects but that seemed to work for me.

Incidentally, I forked this to comment out the puz checksum check because some upstream bug produces a checksum mismatch in certain files with lots of circled squares, but I can't figure out exactly what the issue is. I'm going to try to track it down and report it upstream, but in the meantime, I think you could plausibly skip the checksum check or change the error it throws to a console warning.

@boisvert42
Copy link
Contributor

fwiw i am running into this same issue

@boisvert42
Copy link
Contributor

(specifically, the forked repo one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants