Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: enable written regression tests in derivations #519

Open
3 of 6 tasks
Aleksanaa opened this issue Jun 1, 2024 · 3 comments
Open
3 of 6 tasks

vendor: enable written regression tests in derivations #519

Aleksanaa opened this issue Jun 1, 2024 · 3 comments
Labels
bug Something isn't working tracking Tracking issue

Comments

@Aleksanaa
Copy link
Collaborator

Aleksanaa commented Jun 1, 2024

******************** TEST 'nixd-attrset-eval :: attrs-completion.md' FAILED ********************
Script:
--
: 'RUN: at line 1';   nixd-attrset-eval --lit-test < /build/source/nixd/tools/nixd-attrset-eval/test/attrs-completion.md | FileCheck /build/source/nixd/tools/nixd-attrset-eval/test/attrs-completion.md
--
Exit Code: 2

Command Output (stdout):
--
$ ":" "RUN: at line 1"
$ "nixd-attrset-eval" "--lit-test"
# command stderr:
warning: '/nix/var/nix' does not exist, so Nix will use '/build/.local/share/nix/root' as a chroot store
terminate called after throwing an instance of 'nix::SQLiteBusy'
  what():  �[31;1merror:�[0m SQLite database '�[35;1m/build/.local/share/nix/root/nix/var/nix/db/db.sqlite�[0m' is busy

error: command failed with exit status: -6
$ "FileCheck" "/build/source/nixd/tools/nixd-attrset-eval/test/attrs-completion.md"
# command stderr:
FileCheck error: '<stdin>' is empty.
FileCheck command line:  FileCheck /build/source/nixd/tools/nixd-attrset-eval/test/attrs-completion.md

error: command failed with exit status: 2

--

********************
********************
Failed Tests (1):
  nixd-attrset-eval :: attrs-completion.md
@Aleksanaa Aleksanaa added the bug Something isn't working label Jun 1, 2024
@inclyc
Copy link
Member

inclyc commented Jun 2, 2024

The CI in this project never fails randomly.

https://github.com/nix-community/nixd/actions

60s timeout is not actually enough for single-threaded builds, but sometimes enough (another source of random failures).

Multi-threaded tests make nix sqlite busy, causing random failures in

Maybe just increase the testing time. But as you can see, it is always enough for github CI.

Regression testing nixpkgs-fmt. Instead, a script that outputs specific content should replace it, simply verifying that nixd passed the correct arguments to nixpkgs-fmt.

It won't increase the closure, right? Yes, a single script might be better.

@inclyc
Copy link
Member

inclyc commented Jun 2, 2024

# Disable nixd regression tests, because it uses some features provided by

@inclyc inclyc changed the title Poorly written regression tests for nixd vendor: enable written regression tests in derivations Jun 2, 2024
@inclyc inclyc reopened this Jun 2, 2024
@inclyc
Copy link
Member

inclyc commented Jun 2, 2024

Reopen as it is still planned. Generally we'd like to improve testing coverage in packaging environment. Thanks @Aleksanaa

@inclyc inclyc added the tracking Tracking issue label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracking Tracking issue
Projects
None yet
Development

No branches or pull requests

2 participants