From 215233c84804dd1d0efbff817764f9a9a169afdb Mon Sep 17 00:00:00 2001 From: Sang Huynh Thanh Date: Mon, 15 Jan 2024 16:08:06 +0700 Subject: [PATCH] [#56] Self-review --- package-lock.json | 6 +++--- packages/eslint-config-nimble-core/lib/index.js | 2 +- packages/eslint-config-nimble-typescript/lib/index.js | 2 +- .../eslint-config-nimble-typescript/lib/rules/typescript.js | 5 ----- 4 files changed, 5 insertions(+), 10 deletions(-) diff --git a/package-lock.json b/package-lock.json index bbe6912..42cc704 100644 --- a/package-lock.json +++ b/package-lock.json @@ -10897,7 +10897,7 @@ }, "packages/eslint-config-nimble-core": { "name": "@nimblehq/eslint-config-nimble-core", - "version": "2.7.0", + "version": "2.8.0", "license": "MIT", "dependencies": { "eslint": "^8.51.0", @@ -10948,7 +10948,7 @@ "version": "1.0.0", "license": "MIT", "dependencies": { - "@nimblehq/eslint-config-nimble-core": "^2.7.0", + "@nimblehq/eslint-config-nimble-core": "^2.8.0", "eslint-import-resolver-typescript": "^3.6.1" }, "devDependencies": { @@ -12081,7 +12081,7 @@ "@nimblehq/eslint-config-nimble-typescript": { "version": "file:packages/eslint-config-nimble-typescript", "requires": { - "@nimblehq/eslint-config-nimble-core": "^2.7.0", + "@nimblehq/eslint-config-nimble-core": "^2.8.0", "@typescript-eslint/eslint-plugin": "^6.18.1", "@typescript-eslint/parser": "^6.18.1", "eslint": "^8.56.0", diff --git a/packages/eslint-config-nimble-core/lib/index.js b/packages/eslint-config-nimble-core/lib/index.js index 56d6994..11b883a 100644 --- a/packages/eslint-config-nimble-core/lib/index.js +++ b/packages/eslint-config-nimble-core/lib/index.js @@ -1,6 +1,6 @@ /** * @fileoverview eslint config - * @author Nimbl3 + * @author Nimble */ 'use strict'; diff --git a/packages/eslint-config-nimble-typescript/lib/index.js b/packages/eslint-config-nimble-typescript/lib/index.js index e2ce61a..03fdeec 100644 --- a/packages/eslint-config-nimble-typescript/lib/index.js +++ b/packages/eslint-config-nimble-typescript/lib/index.js @@ -1,5 +1,5 @@ /** - * @fileoverview eslint testing config + * @fileoverview eslint typescript config * @author Nimble */ 'use strict'; diff --git a/packages/eslint-config-nimble-typescript/lib/rules/typescript.js b/packages/eslint-config-nimble-typescript/lib/rules/typescript.js index e4789e3..c046c2d 100644 --- a/packages/eslint-config-nimble-typescript/lib/rules/typescript.js +++ b/packages/eslint-config-nimble-typescript/lib/rules/typescript.js @@ -16,9 +16,4 @@ module.exports = { '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }], '@typescript-eslint/no-use-before-define': ['error'], }, - env: { - browser: true, - commonjs: true, - es2021: true, - }, };