Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous action space should use Independent Normal instead of MultivariateNormal #60

Open
imathg opened this issue Nov 23, 2022 · 1 comment

Comments

@imathg
Copy link

imathg commented Nov 23, 2022

Since in the code you use diagonal covariance matrix, MultivariateNormal deteriorates to Independent Normal.
The former distribution calculates cholesky decomposition, and it is extremely slow when the cov mat is low dimensional (e.g., 4x4), even on gpu.

However, it is quite fast using Independent Normal.

@smiles724
Copy link

Agree with that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants