-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-modal-background-click="disabled" extended #8
Comments
So @goetsu => basically, the alertdialog option has to:
How a user can close it? |
alertdialog are like do you want do confirm suppresion of your account : or like It's the user interaction within the modal that will close it so focus need to be moved in a specific element within the modal that can change depending on the content. Maybe you can do that by adding a data-modal-alertdialog-focustarget data attribute on the target element and move focus on it when the modal open (if used on a not focusable by default element the script will need to add a tabindex="-1" on it otherwise it will not work) Also I forgot that in some case it's best to use aria-describedby on the modal itself see https://www.w3.org/TR/wai-aria-1.1/#alertdialog . Maybe you can do that by adding a data-modal-alertdialog-descriptiontarget data attribut on the target element that will generate a unique id attribute on this element and use this is id on the aria-describedby added to the modal |
So basically, let's sum up: to have a alertdialog:
In fact, we already have the option to give focus to an element (See 4th example: https://van11y.net/downloads/modal/demo/index.html). I suggest to provide focus on the title h1 in the alert modal (so should be with tabindex="-1". Is it ok for you?
Let's separe this case, otherwise it will be too complicated. |
Une modal sans bouton de fermeture pour les cas où c'est nécessaire, +1 ! |
this feature may be use in case of alertdialog instead of dialog so if it's not currently the case this must also prevent to close the dialog using esc key.
Otherwise maybe you can do extra data attributes like :
The text was updated successfully, but these errors were encountered: