Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README update #5

Open
nickrusso42518 opened this issue Mar 15, 2019 · 2 comments
Open

README update #5

nickrusso42518 opened this issue Mar 15, 2019 · 2 comments
Assignees

Comments

@nickrusso42518
Copy link
Owner

Should describe install Makefile target

@nickrusso42518 nickrusso42518 self-assigned this Mar 15, 2019
@pdice
Copy link
Collaborator

pdice commented Mar 15, 2019

I don't think the Makefile approach is consistent with a python based project.

Instead I would expect to be doing:
python setup.py build
python setup.py install

I'd follows this:
https://github.com/pypa/sampleproject
https://packaging.python.org/tutorials/packaging-projects/

@nickrusso42518
Copy link
Owner Author

nickrusso42518 commented Mar 15, 2019

I'm willing to be open minded, but I'm not sure that's appropriate for a consumable utility. The "setup" here is just installing other Python packages, not actually treating this repo as if it were a Python package. Also those commands are 5x more typing than make which is what I use to regression test my changes. If you want to retool the project on a dev branch with this new method after using it for some testing on your end, I'd be happy to talk it over. I think you'll dig the Makefile if you give it a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants