Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent build failures in Travis CI #291

Open
95-martin-orion opened this issue Apr 13, 2020 · 2 comments
Open

Silent build failures in Travis CI #291

95-martin-orion opened this issue Apr 13, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@95-martin-orion
Copy link
Contributor

As seen on this build from PR #290, it appears that Travis will silently fail if the docker run command fails to build qFlex. Silent failures can potentially allow broken code to be submitted, so we need to fix this ASAP. Possible fixes:

  • Enforce waiting for Travis checks prior to submit. (I thought we already did this, but stricter measures are apparently needed).
  • Fix the docker run command to give a Travis-friendly error on build failure. (TBD: why is the current failure mode not Travis-friendly?)

Until this is resolved, please verify that all PRs show Travis checks as complete prior to submitting. Note that due to this bug, the "merge" button might be green without passing Travis checks! Please be careful.

@95-martin-orion 95-martin-orion added the bug Something isn't working label Apr 13, 2020
@95-martin-orion
Copy link
Contributor Author

Further discussion on #290 shows that even successful Travis runs do not show up.

@s-mandra, did we disable the Travis checks? I don't have access to the repo settings, but it should be in there (see this page for how to find it).

@s-mandra
Copy link
Member

Let me take a closer look. Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants