You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As seen on this build from PR #290, it appears that Travis will silently fail if the docker run command fails to build qFlex. Silent failures can potentially allow broken code to be submitted, so we need to fix this ASAP. Possible fixes:
Enforce waiting for Travis checks prior to submit. (I thought we already did this, but stricter measures are apparently needed).
Fix the docker run command to give a Travis-friendly error on build failure. (TBD: why is the current failure mode not Travis-friendly?)
Until this is resolved, please verify that all PRs show Travis checks as complete prior to submitting. Note that due to this bug, the "merge" button might be green without passing Travis checks! Please be careful.
The text was updated successfully, but these errors were encountered:
As seen on this build from PR #290, it appears that Travis will silently fail if the
docker run
command fails to build qFlex. Silent failures can potentially allow broken code to be submitted, so we need to fix this ASAP. Possible fixes:docker run
command to give a Travis-friendly error on build failure. (TBD: why is the current failure mode not Travis-friendly?)Until this is resolved, please verify that all PRs show Travis checks as complete prior to submitting. Note that due to this bug, the "merge" button might be green without passing Travis checks! Please be careful.
The text was updated successfully, but these errors were encountered: