Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve management of cloud infrastructure in tests #1672

Closed
pleshakov opened this issue Mar 12, 2024 · 5 comments
Closed

Improve management of cloud infrastructure in tests #1672

pleshakov opened this issue Mar 12, 2024 · 5 comments
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. tests Pull requests that update tests
Milestone

Comments

@pleshakov
Copy link
Contributor

We use shell scripts https://github.com/nginxinc/nginx-gateway-fabric/tree/15bab00d0f31c96eed0fe29f34ed7373fa0b9646/tests/scripts to provision and deprovision cloud infra on GKE for tests.

One problem with shell scripts - handling partial failures: if some resources were created and some note, re-runing a failed script is not possible because it will fail due to attempts to create already existing resources

Consider using declarative infra management tools to manage infra in tests.

Copy link
Contributor

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Mar 27, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@sjberman sjberman removed the stale Pull requests/issues with no activity label Apr 10, 2024
@sjberman sjberman reopened this Apr 10, 2024
@mpstefan mpstefan added tests Pull requests that update tests backlog Currently unprioritized work. May change with user feedback or as the product progresses. labels Apr 10, 2024
@mpstefan
Copy link
Collaborator

How often does this error occur? How much time does it cost us?

Placed it in the backlog for now.

@pleshakov
Copy link
Contributor Author

example of a clean up that wasn't complete -- https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/9306728832/job/25616520648

clean up failed to delete created cluster

@mpstefan
Copy link
Collaborator

Moved to #2390

@mpstefan mpstefan closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2024
@sindhushiv sindhushiv added this to the v1.5.0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. tests Pull requests that update tests
Projects
None yet
Development

No branches or pull requests

4 participants