Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel chunking #95

Open
LouisLeNezet opened this issue Jul 3, 2024 · 3 comments
Open

Panel chunking #95

LouisLeNezet opened this issue Jul 3, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@LouisLeNezet
Copy link
Collaborator

Description of feature

Do we really need to chunks with Glimpse1 and 2.
I would guess that both of them should produce the same output in the end.
As Glimpse2 has more option, I would suggest to only chunks with the version 2.
What do you think ?

@LouisLeNezet LouisLeNezet added the enhancement New feature or request label Jul 3, 2024
@LouisLeNezet LouisLeNezet self-assigned this Jul 3, 2024
@atrigila
Copy link
Collaborator

atrigila commented Jul 5, 2024

I agree we could do only one type of chunking.

glimpse2 chunking had some issues in the past (I think segmentation fault occurred sometimes) and also it did not work with "sequential" mode.

If we modify that in the nf-core modules, test them and make it work, I think we can add the updated module in phaseimpute and remove glimpse1.

@LouisLeNezet LouisLeNezet added this to the v0.99.0 milestone Jul 5, 2024
@LouisLeNezet
Copy link
Collaborator Author

Glimpse2 effectively seems to have issue when chunking really small regions.
When reducing the size of the buffer we often ran into segmentation fault.

@LouisLeNezet
Copy link
Collaborator Author

This is linked to the following issue on GLIMPSE2_chunk.

@atrigila atrigila modified the milestones: v0.99.0, v1.1.0 Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants