-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check guidelines for release and add corrections #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Can you change the |
3 tasks
2 tasks
LouisLeNezet
requested changes
Oct 29, 2024
LouisLeNezet
approved these changes
Oct 29, 2024
LouisLeNezet
added a commit
to LouisLeNezet/phaseimpute
that referenced
this pull request
Oct 29, 2024
* typo fixes in readme * remove some to-dos * remove todos, add bibliography * add conditional detection of tools * add missing tools to citations * add conditional params * add release name and date * bump versions * add contributors and reviewers * Update README.md * Update README.md * Update README.md --------- Co-authored-by: Louis LE NEZET <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do: nf-core principles
Do: Local code and modules
bin/
have author and license embedded?latest
,dev
etc.)grep
operations not necessaryawk
Do: Documentation
usage.md
,output.md
,nextflow_schema.json
)?default
andenum
are used where applicableusage.md
,output.md
,nextflow_schema.json
)CIATIONS.md
Do: Code
snake_case
false
(e.g. bad:params.run_step = true{:groovy}
, good:params.skip_step = false{:groovy}
)Don't have to do