Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider --illumination manual vs. checking for the presence of the dfp/ffp samplesheet columns #38

Open
jmuhlich opened this issue May 20, 2024 · 0 comments
Labels
enhancement Improvement for existing functionality

Comments

@jmuhlich
Copy link
Member

Description of feature

I realized that --illumination manual may be semi-redundant with including the ffp and/or dfp columns in the sample sheet. We should either add a check in PIPELINE_INITIALISATION that these two things are aligned, or rethink the interface to this feature (perhaps the presence of user-provided illumination profiles would imply illumination="manual" and the illumination param would only serve to invoke basicpy or another future tool).

@jmuhlich jmuhlich added the enhancement Improvement for existing functionality label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant