Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow runs when outdir parameter is missing #18

Closed
RobJY opened this issue Mar 18, 2024 · 3 comments
Closed

workflow runs when outdir parameter is missing #18

RobJY opened this issue Mar 18, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@RobJY
Copy link
Contributor

RobJY commented Mar 18, 2024

Description of the bug

Even though the outdir parameter is defined as required in the schema file the workflow runs when it is missing.

Command used and terminal output

'''
nextflow run ~/github/mcmicro-nf-core/main.nf --input_cycle ~/github/mcmicro-nf-core/assets/samplesheet_1_row_sample_cycle_multi_2.csv --marker_sheet ~/github/mcmicro-nf-core/assets/markers_multi_8.csv -profile test_work -params-file ~/github/mcmicro-nf-core/conf/workflow.json
'''
It runs to completion, but output is stored in a directory named 'null'.

Relevant files

No response

System information

No response

@RobJY RobJY added the bug Something isn't working label Mar 18, 2024
@RobJY RobJY self-assigned this Mar 18, 2024
@RobJY
Copy link
Contributor Author

RobJY commented Mar 18, 2024

I just pushed an update that explicitly checks for the outdir parameter and stops execution with an error message if it's missing.

I still need to figure out why it isn't being caught by the schema check, but this will fix the issue for now.

@RobJY
Copy link
Contributor Author

RobJY commented Mar 18, 2024

Interestingly, if I fail to provide a markersheet I get an error that looks like it's from schema validation as we expect

nextflow.validation.SchemaValidationException:

Still looking into why we don't get the same for a missing outdir parameter

@RobJY
Copy link
Contributor Author

RobJY commented Mar 18, 2024

I had a bug in the schema file and also needed to explicitly declare the path to the testing schema file.
works now.

@RobJY RobJY closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant