Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use typed AppConfig getters in share manager #50115

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

refactor: Use typed AppConfig getters in share manager #50115

wants to merge 1 commit into from
+37 −41

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 9, 2025 •
edited
Loading

Summary

Switch to backward compatible AppConfig getters

TODO

  • Update tests

Checklist

@Pytal Pytal added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 9, 2025
@Pytal Pytal added this to the Nextcloud 31 milestone Jan 9, 2025
@Pytal Pytal requested review from artonge, provokateurin and a team January 9, 2025 23:08
@Pytal Pytal self-assigned this Jan 9, 2025
@Pytal Pytal requested review from sorbaugh and removed request for a team January 9, 2025 23:08
@Pytal Pytal added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 9, 2025
@Pytal Pytal marked this pull request as draft January 9, 2025 23:15
provokateurin
provokateurin approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Draft is not on purpose?

@Pytal
Copy link
Member Author

Pytal commented Jan 10, 2025

Draft is not on purpose?

Nope, need to update some tests 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@artonge artonge Awaiting requested review from artonge

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

@Pytal Pytal

Labels
2. developing Work in progress ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
2 participants
@Pytal @provokateurin