fix(core): Fix undefined "application" array key error #50081
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <[email protected]>
Pytal
requested review from
provokateurin and
come-nc
and removed request for
a team
joshtrichards
approved these changes
Jan 8, 2025
|
Here too maybe? server/core/templates/layout.user.php Line 27 in 1ed3f03 |
provokateurin
approved these changes
Jan 8, 2025
Merged
come-nc
requested changes
Jan 9, 2025
| @@ -10,7 +10,7 @@ | |||
| <meta charset="utf-8"> | |||
| <title> | |||
| <?php | |||
| p(!empty($_['pageTitle']) && $_['pageTitle'] !== $_['application'] ? $_['pageTitle'] . ' - ' : ''); | |||
| p(!empty($_['pageTitle']) && !empty($_['application']) && $_['pageTitle'] !== $_['application'] ? $_['pageTitle'] . ' - ' : ''); | |||
There was a problem hiding this comment.
No, this will hide pageTitle if application is not set, which is not what we want?
There was a problem hiding this comment.
Suggested change
| p(!empty($_['pageTitle']) && !empty($_['application']) && $_['pageTitle'] !== $_['application'] ? $_['pageTitle'] . ' - ' : ''); | |
| p(!empty($_['pageTitle']) && (empty($_['application']) || $_['pageTitle'] !== $_['application']) ? $_['pageTitle'] . ' - ' : ''); |
Maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Undefined array key "application"being loggedChecklist