Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Copying a folder containing live photos causes them to lose their live photo functionality #49289

Open
kesselb opened this issue Nov 14, 2024 · 0 comments · May be fixed by #49293
Open

[Bug]: Copying a folder containing live photos causes them to lose their live photo functionality #49289

kesselb opened this issue Nov 14, 2024 · 0 comments · May be fixed by #49293
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback bug feature: live photos

Comments

@kesselb
Copy link
Contributor

kesselb commented Nov 14, 2024 •
edited
Loading

Bug description

Copying a folder containing live photos causes them to lose their live photo functionality.

Steps to reproduce

  1. Have a folder containing live photos files
  2. Copy the folder somewhere
  3. No more live photos
Screencast.From.2024-11-14.16-19-03.webm

Expected behavior

Live photos should still work

Nextcloud Server version

master

Additional info

The state about live photos in stable28 is a bit weird.

Pull Request Merge date 28 29 30
#41308 2023-11-09 ✅ ✅ ✅
#41601 2023-11-21 ✅ ✅ ✅
#41765 2023-11-30 ✅ ✅ ✅
#42154 2023-12-11 ✅ ✅ ✅
#42170 2024-03-08 ❌ ✅ ✅
#44069 2024-03-14 ✅ ✅ ✅

I think the backport for 42170 to stable28 is worth doing since copying files is pretty important. I gave it a shot, but integrating the changes from 44069 was tricky. My attempt could really use a review and testing from someone more experienced with this feature: https://github.com/nextcloud/server/compare/stable28...backport/42170/stable28?expand=1
@kesselb kesselb added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug 1. to develop Accepted and waiting to be taken care of feature: live photos and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 14, 2024
@artonge artonge linked a pull request Nov 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback bug feature: live photos
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Handle copy of folders containing live photos nextcloud/server
2 participants
@kesselb @szaimen