-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preview): add command to cleanup preview folder #48537
Conversation
d2ab0a7
to
b65598d
Compare
When changing preview parameters (size, format, …), one can simply delete the preview folder and run files:scan-app-data in order to retrigger updated preview recreation because files are absent. However, that's not possible when using ObjectStorage as primary storage, as there's no concept of "preview folder". This command allows to simply delete and recreate the preview folder properly from Nextcloud, so that the abstraction levels handle all the subfolder & file deleting part. Signed-off-by: Thomas Citharel <[email protected]>
b65598d
to
fe0f89c
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Ref nextcloud/server#48537 Signed-off-by: Thomas Citharel <[email protected]>
Documented at nextcloud/documentation#12486 |
Ref nextcloud/server#48537 Signed-off-by: Thomas Citharel <[email protected]>
Summary
When changing preview parameters (size, format, …), one can simply delete the
appdata_xxx/preview
folder and runfiles:scan-app-data
in order to retrigger updated preview recreation because files are absent.However, that's not possible when using ObjectStorage as primary storage, as there's no concept of "preview folder".
This command allows to simply delete and recreate the preview folder properly from Nextcloud, so that the abstraction levels handle all the subfolder & file deleting part.
Possible concerns : deleting all preview files from object storage in a single command might take a while, so even if we don't have a timeout because this is a command, it might be nice to have some kind of a warning before. Possibly a confirmation step.
Checklist