Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preview): add command to cleanup preview folder #48537

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

tcitworld
Copy link
Member

Summary

When changing preview parameters (size, format, …), one can simply delete the appdata_xxx/preview folder and run files:scan-app-data in order to retrigger updated preview recreation because files are absent.

However, that's not possible when using ObjectStorage as primary storage, as there's no concept of "preview folder".

This command allows to simply delete and recreate the preview folder properly from Nextcloud, so that the abstraction levels handle all the subfolder & file deleting part.

Possible concerns : deleting all preview files from object storage in a single command might take a while, so even if we don't have a timeout because this is a command, it might be nice to have some kind of a warning before. Possibly a confirmation step.

Checklist

@tcitworld tcitworld added this to the Nextcloud 31 milestone Oct 2, 2024
@tcitworld tcitworld force-pushed the add-command-to-cleanup-preview branch 3 times, most recently from d2ab0a7 to b65598d Compare October 3, 2024 07:16
core/Command/Preview/Cleanup.php Outdated Show resolved Hide resolved
core/Command/Preview/Cleanup.php Outdated Show resolved Hide resolved
tests/Core/Command/Preview/CleanupTest.php Outdated Show resolved Hide resolved
When changing preview parameters (size, format, …), one can simply delete the preview folder and run
files:scan-app-data in order to retrigger updated preview recreation because files are absent.

However, that's not possible when using ObjectStorage as primary storage, as there's no concept of
"preview folder".

This command allows to simply delete and recreate the preview folder properly from
Nextcloud, so that the abstraction levels handle all the subfolder & file deleting part.

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld force-pushed the add-command-to-cleanup-preview branch from b65598d to fe0f89c Compare October 3, 2024 11:41
@tcitworld tcitworld requested a review from come-nc October 3, 2024 11:55
@tcitworld tcitworld requested review from a team and provokateurin and removed request for a team October 14, 2024 06:39
@provokateurin provokateurin merged commit 10d1c3c into master Oct 14, 2024
177 checks passed
@provokateurin provokateurin deleted the add-command-to-cleanup-preview branch October 14, 2024 06:57
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@tcitworld
Copy link
Member Author

Documented at nextcloud/documentation#12486

@tcitworld tcitworld removed the pending documentation This pull request needs an associated documentation update label Jan 7, 2025
backportbot bot pushed a commit to nextcloud/documentation that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants