Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: UI for JSON (Google Takeout) Favorites Import missing #1342

Open
6 of 9 tasks
thisisjoesGH opened this issue Oct 20, 2024 · 1 comment
Open
6 of 9 tasks

[Bug]: UI for JSON (Google Takeout) Favorites Import missing #1342

thisisjoesGH opened this issue Oct 20, 2024 · 1 comment

Comments

@thisisjoesGH
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

The ability to import favorites from Google Takeout data was added in #338, but the original UI it used appears to have been removed in 64a8788. I am unable to find any way in the current UI to import favorites. The only current visible "import" feature is the device import which does not apparently support JSON files, the file picker it shows says:

Import devices from gpx (Nextcloud Maps) or kml/kmz (Google Timeline) file

Related: #1205

Favorites sidebar context menu:
Image
Favorites category context menu:
Image

Steps to reproduce

  1. Install Nextcloud Maps
  2. Attempt to import saved locations from Google Maps from a JSON file downloaded through Google Takeout
  3. Find no usable import option

Expected behavior

Present user with option to import JSON files from Google Takeout somewhere in the UI

Installation method

Official SNAP package

Operating system

Other

PHP engine version

Other

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install of the server?

None

Is this bug present after an update or on a fresh install of the app?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
"system": {
"apps_paths": [
{
"path": "/snap/nextcloud/current/htdocs/apps",
"url": "/apps",
"writable": false
},
{
"path": "/var/snap/nextcloud/current/nextcloud/extra-apps",
"url": "/extra-apps",
"writable": true
}
],
"supportedDatabases": [
"mysql"
],
"memcache.locking": "\OC\Memcache\Redis",
"memcache.local": "\OC\Memcache\Redis",
"redis": {
"host": "REMOVED SENSITIVE VALUE",
"port": 0
},
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
"REMOVED SENSITIVE VALUE",
"REMOVED SENSITIVE VALUE",
"localhost"
],
"datadirectory": "REMOVED SENSITIVE VALUE",
"dbtype": "mysql",
"version": "28.0.11.1",
"overwrite.cli.url": "REMOVED SENSITIVE VALUE",
"dbname": "REMOVED SENSITIVE VALUE",
"dbhost": "REMOVED SENSITIVE VALUE",
"dbport": "",
"dbtableprefix": "oc_",
"mysql.utf8mb4": true,
"dbuser": "REMOVED SENSITIVE VALUE",
"dbpassword": "REMOVED SENSITIVE VALUE",
"installed": true,
"instanceid": "REMOVED SENSITIVE VALUE",
"mail_smtpmode": "smtp",
"mail_sendmailmode": "smtp",
"mail_smtphost": "REMOVED SENSITIVE VALUE",
"mail_domain": "REMOVED SENSITIVE VALUE",
"loglevel": 0,
"maintenance": false,
"twofactor_enforced": "false",
"twofactor_enforced_groups": [],
"twofactor_enforced_excluded_groups": [],
"mail_from_address": "REMOVED SENSITIVE VALUE",
"mail_smtpsecure": "tls",
"mail_smtpport": "587",
"app_install_overwrite": [
"files_accesscontrol",
"bookmarks_fulltextsearch",
"files_downloadactivity"
],
"theme": "",
"has_rebuilt_cache": true,
"mail_smtpauthtype": "PLAIN",
"mail_smtpauth": 1,
"mail_smtpname": "REMOVED SENSITIVE VALUE",
"mail_smtppassword": "REMOVED SENSITIVE VALUE",
"encryption.legacy_format_support": true,
"encryption.key_storage_migrated": false,
"encryption.legacy_format_support=false": "",
"memories.exiftool": "/var/snap/nextcloud/44703/nextcloud/extra-apps/memories/bin-ext/exiftool-amd64-glibc",
"memories.vod.path": "/var/snap/nextcloud/44703/nextcloud/extra-apps/memories/bin-ext/go-vod-amd64",
"preview_max_x": 2048,
"preview_max_y": 2048,
"memories.db.triggers.fcu": true,
"ldapProviderFactory": "OCA\User_LDAP\LDAPProviderFactory",
"enforce_theme": "",
"maintenance_window_start": 1
}
}

List of activated Apps

  • activity: 2.20.0
  • admin_audit: 1.18.0
  • announcementcenter: 7.0.1
  • bookmarks: 14.2.6
  • breezedark: 28.0.1
  • bruteforcesettings: 2.8.0
  • calendar: 4.7.16
  • carnet: 0.25.6
  • checksum: 1.2.5
  • circles: 28.0.0
  • cloud_federation_api: 1.11.0
  • comments: 1.18.0
  • contacts: 5.5.3
  • contactsinteraction: 1.9.0
  • cookbook: 0.11.2
  • dashboard: 7.8.0
  • dav: 1.29.2
  • end_to_end_encryption: 1.14.5
  • epubviewer: 1.6.3
  • federatedfilesharing: 1.18.0
  • federation: 1.18.0
  • files: 2.0.0
  • files_accesscontrol: 1.18.1
  • files_external: 1.20.0
  • files_fulltextsearch: 28.0.1
  • files_mindmap: 0.0.30
  • files_pdfviewer: 2.9.0
  • files_reminders: 1.1.0
  • files_sharing: 1.20.0
  • files_trashbin: 1.18.0
  • files_versions: 1.21.0
  • firstrunwizard: 2.17.0
  • logreader: 2.13.0
  • lookup_server_connector: 1.16.0
  • maps: 1.4.0
  • memories: 7.4.1
  • metadata: 0.21.0
  • music: 2.0.1
  • nextcloud_announcements: 1.17.0
  • notifications: 2.16.0
  • oauth2: 1.16.4
  • onlyoffice: 9.4.0
  • password_policy: 1.18.0
  • phonetrack: 0.8.1
  • photos: 2.4.0
  • previewgenerator: 5.6.0
  • privacy: 1.12.0
  • provisioning_api: 1.18.0
  • qownnotesapi: 24.9.0
  • quota_warning: 1.20.0
  • recommendations: 2.0.0
  • related_resources: 1.3.0
  • serverinfo: 1.18.0
  • settings: 1.10.1
  • sharebymail: 1.18.0
  • spreed: 18.0.12
  • suspicious_login: 6.0.0
  • systemtags: 1.18.0
  • tasks: 0.16.1
  • text: 3.9.2
  • theming: 2.3.0
  • twofactor_backupcodes: 1.17.0
  • twofactor_totp: 10.0.0-beta.2
  • user_ldap: 1.19.0
  • user_status: 1.8.1
  • viewer: 2.2.0
  • weather_status: 1.8.0
  • workflowengine: 2.10.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Browser Console

No response

Additional info

PHP engine version: 8.2 as per the Nextcloud Snap

Thanks for your work on the Nextcloud Maps app!

@TheRaven500
Copy link

It is not only "import" what is missing "delete" is also missing for favorites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants