Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials Provider Framework Tab Issue #12121

Open
AsadRazaJutt1 opened this issue Oct 25, 2024 · 3 comments
Open

Credentials Provider Framework Tab Issue #12121

AsadRazaJutt1 opened this issue Oct 25, 2024 · 3 comments
Labels
triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.

Comments

@AsadRazaJutt1
Copy link

What is the improvement or update you wish to see?

Framework Tab is not working well in context of specific selected tab.

Is there any context that might help us understand?

There are four frameworks: Next.js, Svelte, Qwik, and Express. However, when I click on Next.js (Client), examples from the Qwik framework are selected instead

Does the docs page already exist? Please link to it.

https://authjs.dev/getting-started/authentication/credentials

@AsadRazaJutt1 AsadRazaJutt1 added the triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. label Oct 25, 2024
@halvaradop
Copy link
Contributor

The behavior we're seeing is expected due to how the selected framework operates as an index. When you switch between frameworks, you’re updating this index, which is why you might see both Qwik and Next.js (Client) in different sections.

In my view, this approach is effective for managing the selected framework, especially since some pages may feature four frameworks while others have five. This variability could lead to conflicts in determining which framework should be displayed.

For instance, if you select Qwik, the code in both the Credentials Provider and Signin Form sections aligns correctly. However, if you then choose Next.js (Client) in the Signin Form, it raises the question: what content should be displayed in the Credentials Provider section?

This is just my opinion, and I think it would be beneficial to wait for a maintainer’s input on this matter.

@AsadRazaJutt1
Copy link
Author

Can I resolve it and create a pull request? If you have any suggestions, I’ll keep them in mind.

@halvaradop
Copy link
Contributor

I have created a pull request that adds a slugified version of the tabs, which is related to this issue. If you’d like to see it, please check PR #11951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.
Projects
None yet
Development

No branches or pull requests

2 participants