Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login with identity config instead of separate cert/key #9

Open
qrkourier opened this issue Nov 18, 2024 · 4 comments
Open

login with identity config instead of separate cert/key #9

qrkourier opened this issue Nov 18, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@qrkourier
Copy link
Member

The ziti edge enroll command is the easiest way to obtain an admin client cert. This produces a Ziti identity configuration JSON file, which can be used by the Go SDK to log in like this: https://github.com/openziti/ziti/blob/v1.2.0/ziti/cmd/edge/login.go#L114

@qrkourier
Copy link
Member Author

I assume this will eliminate the step of running ziti ops unwrap to obtain the separate client cert and private key.

@qrkourier
Copy link
Member Author

Does NF_IDENTITY_PATH already do this?

@qrkourier qrkourier added the enhancement New feature or request label Nov 18, 2024
@qrkourier
Copy link
Member Author

Now I see NF_ADMIN_IDENTITY_PATH is used two ways:

  1. the agent's login
  2. the demo's Postman login

The separate files are only necessary for the Postman demo, and I don't expect most users will use the demo. Most will proceed straight to deployment instructions.

Therefore, I think it's best to eliminate the dependency on jq by using the identity config JSON file created by ziti edge enroll directly in the Go SDK where we log in the agent to the mgmt API.

@dariuszSki
Copy link
Member

dariuszSki commented Nov 19, 2024

Right now users need to deploy the webhook using the deployment option. How they pass the parameters needed to run the webhook is up to them. Eventually, the idea would be to go with operator. For right now here are the options:

commandline:

webhookCmd.Flags().StringVar(&certFile, "tls-cert-file", "",

env vars:

func lookupEnvVars() {

For example, we are not requiring users to get the ziti admin user certs a particular way, but only ask to provide them to the webhook two ways described above..

@qrkourier qrkourier self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants