-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diode overriding unwanted data #185
Comments
Thanks @dga-nagra, before we dig deeper with troubleshooting, could you share the following:
|
For diode images, I wasn't able to find the corresponding tag as I was on Let me know if you need anything else. I guess I should retry with a newer version ? |
Hi @dga-nagra, thanks for sharing more information. Diode works around NetBox constraints and i.e. device requires site, and interface requires device, so they way we go around it is to create required but not provided nested objects as |
Sorry I thought I already responded last week.. The reason why the site is required on creation is understood, this is not the issue.
In short: better control over consolidation (e.g. how we find the matching device), the operations we want (update_or_create, update_only, ...) and the data to use (absent != null) Right now, we are unable to use Diode because of these reasons. This could be solved with a script launched from Netbox, but we are willing to support Diode project and would be glad to contribute. Let me know if I can help by any mean. Have a nice day. |
Hi again @mfiedorowicz I was wondering if there was any advancement on this issue? We are reaching some deadlines and, if we are not able to fixe these issues soon, we will need to consider writing a script.. Thank you in advance for the feedback. |
Hi @dga-nagra, we're looking into this issue. Would it possible to extract example ingestion input from i.e. diode-reconciler container logs to help us reproduce this behaviour leading to i.e. overriding chassis object to null? |
Hi,
First, thank you for diode. Data ingestion is indeed a must have for most people, including us.
We were trying to use diode with diode-napalm-agent and we got the following unwanted change:
As we can see, the following fields were overriden:
Here, the change is unexpected as the code doesn't serialize any of these values:
And I think it is the same for the site field if we don't define its value in the discovery policy.
Here, we expect diode to do the change, but he choose to replace "IOS-XE" with "IOS" which is less precise.
We expect Diode to ignore fields that are not provided instead of overriding them with
null
, and keep the more exact valuewhen possible.
Another behavior is that, if we don't provide the site, Diode will not find the device and create a new one a new site called
undefined
. Again, we expected Diode to find an existing device in any existing site even if not provided in the discovery policies.Is there an option to change these behaviors ?
Basically, we expect Diode to only override information that are provided explicitly.
Thank you in advance for your response. We are also willing to help if you need someone to test or implement something.
The text was updated successfully, but these errors were encountered: