Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate logic for rendering configuration templates #18208

Open
jeremystretch opened this issue Dec 11, 2024 · 0 comments
Open

Consolidate logic for rendering configuration templates #18208

jeremystretch opened this issue Dec 11, 2024 · 0 comments
Labels
status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Introduce a mixin class and common HTML template to handle rendering configuration templates for both devices and virtual machines.

Justification

DeviceRenderConfigView and VirtualMachineRenderConfigView are largely redundant. Introducing a common parent mixin and inclusion template will reduce duplicate code.
@jeremystretch jeremystretch added type: housekeeping Changes to the application which do not directly impact the end user status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremystretch