Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Proxy support #55

Open
gthieleb opened this issue Aug 11, 2017 · 2 comments
Open

Native Proxy support #55

gthieleb opened this issue Aug 11, 2017 · 2 comments

Comments

@gthieleb
Copy link

For a script within customer network there is a need for proxy support.

What works is using environment http_proxy / https_proxy which is luckely supported from the requests module. But this is kind unflexible when accessing an external and internal taiga instance at the same time.

Where is a good starting point, adding proxy support to this module?

@yakky
Copy link
Member

yakky commented Aug 11, 2017

@gthieleb https://github.com/nephila/python-taiga/blob/master/taiga/requestmaker.py and auth* methods (https://github.com/nephila/python-taiga/blob/master/taiga/client.py#L138 and https://github.com/nephila/python-taiga/blob/master/taiga/client.py#L182) are the points where requests is called.
Adding a proxy argument to TaigaAPI init (https://github.com/nephila/python-taiga/blob/master/taiga/client.py#L53) and the passing it to requests where needed should be the best way to achieve this

@yakky
Copy link
Member

yakky commented Dec 30, 2017

@gthieleb do you need any help to contribute this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants