Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate NEON_NODE_ABI environment variable #241

Closed
dherman opened this issue Sep 18, 2017 · 0 comments
Closed

eliminate NEON_NODE_ABI environment variable #241

dherman opened this issue Sep 18, 2017 · 0 comments

Comments

@dherman
Copy link
Collaborator

dherman commented Sep 18, 2017

From @dherman on January 9, 2017 20:57

With #109 we extract the node modules ABI version number from the headers instead of pulling it from the environment variable. When we upgrade to neon 0.2 we should get rid of the environment variable entirely.

(This was done in #37 but rolled back in #41 to wait until we're ready for 0.2.)

Copied from original issue: neon-bindings/neon-cli#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants