Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels css have swapped background and font colors in var names #241

Open
stefano-ottolenghi opened this issue Jul 15, 2024 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@stefano-ottolenghi
Copy link
Contributor

For example,

span.label--discontinued {
  background: var(--discontinued-color);
  color: var(--discontinued-background-color);
}

var for background lacks background in name and viceversa. Applies probably to all except for deprecated.

@stefano-ottolenghi stefano-ottolenghi added the good first issue Good for newcomers label Jul 15, 2024
stefano-ottolenghi added a commit that referenced this issue Jul 15, 2024
To create visual difference between removals and deprecations. 

Result:
![Screenshot from 2024-07-15
11-58-53](https://github.com/user-attachments/assets/065299c1-4567-4fb2-8ecb-6305f0cdc682)

Spawned #241.
recrwplay pushed a commit to recrwplay/docs-ui that referenced this issue Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant