Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed images in notebook #3

Open
prudhomm opened this issue Oct 16, 2022 · 4 comments
Open

embed images in notebook #3

prudhomm opened this issue Oct 16, 2022 · 4 comments

Comments

@prudhomm
Copy link
Contributor

prudhomm commented Oct 16, 2022

Hi @Mogztter

is it already possible to embed an image in a jupyter notebook using this extension ?
that would be great!
I use already env-github and env-vscode to detect github or vscode and provide the path
maybe env-jupyter is needed ?

For example here is the type of adoc that will be used to generate a jupyter notebook:
https://github.com/feelpp/toolbox/edit/master/examples/modules/csm/pages/suspension/index.adoc
here is how it looks in antora
https://docs.feelpp.org/cases/latest/csm/suspension/index.html

I have often many images and I am adding python code as well atm to make the notebook more interesting

images in tables do not seem to be working properly

@ggrossetie
Copy link
Contributor

I use already env-github and env-vscode to detect github or vscode and provide the path
maybe env-jupyter is needed ?

I think you should use the attribute backend-jupyter. A converter should not set env- attribute since is meant to indicate which environment Asciidoctor is being integrated into. For instance, the env could be env-jupyterlab (desktop) or env-jupyterhub (web) if you are targeting one environment or the other.

images in tables do not seem to be working properly

For now, only text is supported in tables.

@prudhomm
Copy link
Contributor Author

thanks!

backend-jupyter works nicely.
However the control over the image sizes do not seem to work.

I will remove the images from the table then and try using asciidoc positioning

@prudhomm
Copy link
Contributor Author

@Mogztter I have added at the top of the adoc a button to download the jupyter notebook. As you can see the images are not embedded. Otherwise it seems all good.
https://docs.feelpp.org/cases/latest/csm/sensor/index.html

@prudhomm
Copy link
Contributor Author

The images are not embedded in the jupyter notebook it seems. Would it be possible to do so in order to share the notebook ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants