Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue to format other files after error #22

Open
nevans opened this issue Mar 28, 2023 · 2 comments
Open

Continue to format other files after error #22

nevans opened this issue Mar 28, 2023 · 2 comments
Assignees
Labels
looking for contributions This issue was accepted and is looking for a pull-request

Comments

@nevans
Copy link

nevans commented Mar 28, 2023

When one file has an parse error, I would prefer that formatting continues for all of the other files that have no issue (after printing the error message). There should be a command line flag to enable or disable this behavior. My preference is to continue by default, but fail-fast by default (i.e. the current behavior) would be fine too.

@nevans nevans changed the title Continue to to format other files after error Continue to format other files after error Mar 28, 2023
@elia
Copy link
Member

elia commented Jul 7, 2023

@nevans that works for me:

  • I think stopping by default would be less surprising
  • it should save up alle the error objects and exit with ≠ 0 if any error occurred
  • errors should be shown at the end printing them on $stderr

Any chance you could try to send a PR for that?

@elia elia self-assigned this Jul 7, 2023
@elia
Copy link
Member

elia commented Jul 7, 2023

Upon further thinking I think the option can be named --no-fail-fast and also accept --fail-fast which would be on by default.

This is tangentially related to #17

@elia elia added the looking for contributions This issue was accepted and is looking for a pull-request label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
looking for contributions This issue was accepted and is looking for a pull-request
Projects
None yet
Development

No branches or pull requests

2 participants