Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for date based expiration #16

Open
marcelovilla opened this issue May 22, 2024 · 2 comments
Open

Add support for date based expiration #16

marcelovilla opened this issue May 22, 2024 · 2 comments

Comments

@marcelovilla
Copy link
Member

marcelovilla commented May 22, 2024

Is your feature request related to a problem? Please describe.
Currently, the configuration parameter account_expiration_days allows to specify an arbitrary number of days after which the registered user will be disabled via Keycloak.

Describe the solution you'd like
It would be nice to have the option of specifying an arbitrary date of user expiration instead a number of days in some cases.

Describe alternatives you've considered
We could expose another exclusive configuration option such as account_expiration_date or update the existing parameter to accept either an integer with the number of days or a proper date formatted string, and rename it to something like account_expiration.

Additional context

@kenafoster
Copy link
Contributor

kenafoster commented May 23, 2024

Interesting - this wasn't needed for the specific use case against which the plugin was initially developed but I definitely see the value in it. My vote would be exclusive configuration options account_expiration_days and account_expiration_date (easiest for administrators to understand and also backwards-compatible)

@marcelovilla
Copy link
Member Author

Thanks, @kenafoster. I agree that having two exclusive fields might be more intuitive and we can always add some validations to the pydantic schema to make sure only one is provided. I'll start working on this and open a PR as soon as I have something for you to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants