-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new deploy app command #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, amazing! You should be able to manually update the snapshots by downloading the files from https://github.com/nebari-dev/jupyterlab-jhub-apps/actions/runs/11022641935?pr=1
Let's see if bot works here:
bot please update snapshots
bot please update snapshots |
...ests/jupyterlab_jhub_apps.spec.ts-snapshots/notebook-context-menu-with-deploy-app-darwin.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this did not work. Maybe needs a timeout?
Looking at the darwin snapshot:
- the kernel busy indicator (the black circle) will flip on and off depending on the kernel state; we may want to ensure that kernel is in idle state (have a look at the tests in JupyterLab to see how to do that)
- the deploy icon looks great here; I think the mockups also included a "Deploy App" label when displayed in the toolbar, do you want to include it straight away or in a follow-up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add the "Deploy App" label in the toolbar in a follow-up PR, just to try and get this PR merged.
bot please update snapshots |
Updating snapshots failed because of timeouts I think: https://github.com/nebari-dev/jupyterlab-jhub-apps/actions/runs/11060426290/job/30730934981 |
bot please update snapshots |
bot please update snapshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nenb!
For context, this PR was previously reviewed in nebari-dev/jupyterlab-nebari-mode#7.
This PR adds a new command:
deploy-app
.deploy-app
create-app
page in a new browser tab. Also passes a query parameter forfilepath
that is generated from the current workspace in JLab. Accepts an argumentorigin
('menu', 'context-menu' etc) that allows controlling what icon is displayed.Reference Issues or PRs
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?
Original issue: nebari-dev/jhub-apps#472