Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back windows support? #2074

Closed
Borwe opened this issue Aug 23, 2023 · 12 comments
Closed

Add back windows support? #2074

Borwe opened this issue Aug 23, 2023 · 12 comments

Comments

@Borwe
Copy link

Borwe commented Aug 23, 2023

I just noticed that the new version doesn't support windows, but old one I had on my system used to.
I now can't use this since WSL2 won't run on my Windows install due to low RAM.
Was wondering if PRs are open to add it back? Or why was it removed?

@frol
Copy link
Collaborator

frol commented Aug 28, 2023

@Borwe I don't have Windows, and I guess it was not a conscious action that caused this regression. We are open for PRs!

@Borwe
Copy link
Author

Borwe commented Oct 31, 2023

I have a fork working for pure windows, but it fails at npm install of intergration-tests, I am wondering if I could create a PR, that when RUN on windows, it would warn the user about breakage when trying to use intergration tests in the genreation process, would that be okay?

@frol
Copy link
Collaborator

frol commented Oct 31, 2023

@Borwe Sounds list a reasonable workaround to me, but can you dig and report the root cause for the issue?

@Borwe
Copy link
Author

Borwe commented Nov 3, 2023

Here is the root cause, seems it's a sandbox problem.

@ChaoticTempest
Copy link
Member

For context, sandbox cannot be supported on windows due to nearcore not being compilable/supported on windows. There's a potential way to get it working on windows, but all tests would have to be pointed to testnet. There's a feature in https://github.com/near/near-workspaces-rs that supports not utilizing a sandbox and only purely working with mainnet and testnet

@frol
Copy link
Collaborator

frol commented Nov 15, 2023

I see, well, I don't expect anyone to put their effort into making nearcore to operate on Windows, but I also don't see near-workspaces-js in the dependency tree of create-near-app. @Borwe Can you provide a screenshot of what you are running and the error? PR is also welcome

@Borwe
Copy link
Author

Borwe commented Apr 15, 2024

Unfortunately I am back on a Windows machine lol. @frol here is the location where near-workspaces is used.
here

And now that there is rust for itnergration tests here it is too

I tried compiling the rust version to track where exactly it is failing, it all boils down to this line
platform(), returns None since on Windows, but I was wondering if we could use some kind of a docker wrapper for windows? Since all that seems to do essentially is download a blob from the internet, which can be traced back to the
call.

@Borwe
Copy link
Author

Borwe commented Apr 15, 2024

Also BTW I notice there is already a Dockerfile on github. There is even a docker image on docker hub for nearcore.

@github-project-automation github-project-automation bot moved this to Backlog 🥶 in DevRel Jun 3, 2024
@gagdiez
Copy link
Collaborator

gagdiez commented Jul 22, 2024

we took some time to study this on depth and apparently it would not be possible since multiple packages are not compatible with windows (the most important ones being near-sdk-rs and near-workspaces

Because of this we will not be able to bring back windows support. To mitigate problems, we decided to write a guide on how to use WSL on windows and added it to our quickstart guide

@gagdiez gagdiez closed this as completed Jul 22, 2024
@github-project-automation github-project-automation bot moved this from Backlog 🥶 to Shipped 🚀 in DevRel Jul 22, 2024
@frol
Copy link
Collaborator

frol commented Aug 1, 2024

@gagdiez Does create-near-app work on Windows for frontend scaffolding?

Can create-near-app print a warning/error for Windows users and guide them to the blog post that explains WSL path?

@gagdiez
Copy link
Collaborator

gagdiez commented Aug 5, 2024

@frol I changed the message to point towards the blogpost 2 weeks ago:

{yellow Learn more here: https://docs.near.org/blog/getting-started-on-windows}

I'll check now if our frontend works on windows

@gagdiez
Copy link
Collaborator

gagdiez commented Aug 5, 2024

@frol good catch: #2155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants