From 9167cd3b36055d631fc3868d88e7b195ef8f7fb8 Mon Sep 17 00:00:00 2001 From: Michelle Melton Date: Fri, 15 Mar 2024 08:22:30 -0400 Subject: [PATCH 1/2] Add css class and style for Excel icon for export of participants for #579 --- participants.php | 3 ++- styles.css | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/participants.php b/participants.php index a8846666..4576ed7f 100644 --- a/participants.php +++ b/participants.php @@ -166,7 +166,8 @@ 'export' => 'xls', ]); $xlsstring = get_string('application/vnd.ms-excel', 'mimetypes'); - $xlsicon = html_writer::img($OUTPUT->image_url('f/spreadsheet'), $xlsstring, ['title' => $xlsstring]); + $xlsicon = html_writer::img($OUTPUT->image_url('f/spreadsheet'), $xlsstring, + ['title' => $xlsstring, 'class' => 'mimetypeicon']); echo get_string('export', 'mod_zoom') . ': ' . html_writer::link($exporturl, $xlsicon); echo $OUTPUT->footer(); diff --git a/styles.css b/styles.css index f05a3c52..a695cb2f 100644 --- a/styles.css +++ b/styles.css @@ -42,3 +42,8 @@ border: none; } +#page-mod-zoom-participants .mimetypeicon { + width: 24px; + height: 24px; +} + From 5db97dabd908e56859be1127e37e1783b0ffcb85 Mon Sep 17 00:00:00 2001 From: Jonathan Champ Date: Thu, 14 Mar 2024 11:10:06 -0400 Subject: [PATCH 2/2] phpcs: Moodle Code Checker v3.4.1 --- tests/advanced_passcode_test.php | 2 +- tests/error_handling_test.php | 2 +- tests/get_meeting_reports_test.php | 2 +- tests/mod_zoom_grade_test.php | 2 +- tests/mod_zoom_invitation_test.php | 2 +- tests/mod_zoom_webservice_test.php | 2 +- tests/privacy/mod_zoom_provider_test.php | 2 +- view.php | 1 + 8 files changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/advanced_passcode_test.php b/tests/advanced_passcode_test.php index 77549162..54d7e87e 100644 --- a/tests/advanced_passcode_test.php +++ b/tests/advanced_passcode_test.php @@ -29,7 +29,7 @@ /** * PHPunit testcase class. */ -class advanced_passcode_test extends basic_testcase { +final class advanced_passcode_test extends basic_testcase { /** * Fake data from get_user_security_settings(). * @var object diff --git a/tests/error_handling_test.php b/tests/error_handling_test.php index 51446625..729a4f1f 100644 --- a/tests/error_handling_test.php +++ b/tests/error_handling_test.php @@ -29,7 +29,7 @@ /** * PHPunit testcase class. */ -class error_handling_test extends basic_testcase { +final class error_handling_test extends basic_testcase { /** * Exception for when the meeting isn't found on Zoom. * @var not_found_exception diff --git a/tests/get_meeting_reports_test.php b/tests/get_meeting_reports_test.php index bd1cde66..273b07b1 100644 --- a/tests/get_meeting_reports_test.php +++ b/tests/get_meeting_reports_test.php @@ -34,7 +34,7 @@ * PHPunit testcase class. * @covers \mod_zoom\task\get_meeting_reports */ -class get_meeting_reports_test extends advanced_testcase { +final class get_meeting_reports_test extends advanced_testcase { /** * Scheduled task object. * @var \mod_zoom\task\get_meeting_reports diff --git a/tests/mod_zoom_grade_test.php b/tests/mod_zoom_grade_test.php index 22fade56..8d8f41ad 100644 --- a/tests/mod_zoom_grade_test.php +++ b/tests/mod_zoom_grade_test.php @@ -29,7 +29,7 @@ /** * PHPunit testcase class. */ -class mod_zoom_grade_test extends advanced_testcase { +final class mod_zoom_grade_test extends advanced_testcase { /** * @var \stdClass Course record. */ diff --git a/tests/mod_zoom_invitation_test.php b/tests/mod_zoom_invitation_test.php index 26f23dc0..9b8f9004 100644 --- a/tests/mod_zoom_invitation_test.php +++ b/tests/mod_zoom_invitation_test.php @@ -34,7 +34,7 @@ * PHPunit testcase class for invitations. * @covers \mod_zoom\invitation */ -class mod_zoom_invitation_test extends advanced_testcase { +final class mod_zoom_invitation_test extends advanced_testcase { /** * Setup to ensure that fixtures are loaded. */ diff --git a/tests/mod_zoom_webservice_test.php b/tests/mod_zoom_webservice_test.php index 1f551931..d126b74f 100644 --- a/tests/mod_zoom_webservice_test.php +++ b/tests/mod_zoom_webservice_test.php @@ -30,7 +30,7 @@ * PHPunit testcase class. * @covers \mod_zoom\webservice */ -class mod_zoom_webservice_test extends advanced_testcase { +final class mod_zoom_webservice_test extends advanced_testcase { /** * @var object Anonymous class to mock \curl. */ diff --git a/tests/privacy/mod_zoom_provider_test.php b/tests/privacy/mod_zoom_provider_test.php index de12490a..85efec3d 100644 --- a/tests/privacy/mod_zoom_provider_test.php +++ b/tests/privacy/mod_zoom_provider_test.php @@ -35,7 +35,7 @@ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later * @coversDefaultClass \mod_zoom\privacy\provider */ -class mod_zoom_provider_test extends provider_testcase { +final class mod_zoom_provider_test extends provider_testcase { /** @var object The zoom instance object. */ protected $zoominstance; diff --git a/view.php b/view.php index 9b89a2a3..d946ec9f 100755 --- a/view.php +++ b/view.php @@ -94,6 +94,7 @@ * Get the display name for a Zoom user. * This is wrapped in a function to avoid unnecessary API calls. * + * @package mod_zoom * @param string $zoomuserid Zoom user ID. * @return ?string */