Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in UE 5.1 #329

Open
Hannessa opened this issue Jan 12, 2023 · 10 comments
Open

Not working in UE 5.1 #329

Hannessa opened this issue Jan 12, 2023 · 10 comments

Comments

@Hannessa
Copy link

Hi,

I tried to install Unreal.js in a brand new UE 5.1 project, following the instructions in the readme. However, I just get the following error message when I try to rebuild it:

image

image

image

@Hannessa
Copy link
Author

Hannessa commented Feb 2, 2023

Here's a list of the compile errors I get:

image

@Hannessa
Copy link
Author

Hannessa commented Feb 2, 2023

I managed to solve half of them by just adding

#include "EditorStyleSet.h"

at the top of SJavascriptGraphEdNode.cpp

@dustout
Copy link

dustout commented Feb 2, 2023

I ran into the same issue and ended up rolling back to UE5, am happy to know I am not the only one having this problem

@Hannessa
Copy link
Author

Hannessa commented Feb 2, 2023

Yeah, same here, good to know! I also rolled back, but I do want to start switching to UE5.1 soon thanks to the much improved foliage rendering.

I also added:
#include "EditorStyleSet.h"
to JavascriptEditorTab.cpp (on row 5 below #if WITH_EDITOR)

and I'm now down to 17 errors. So that gives me some hope that it might mostly be easy fixes.

image

Not quite sure why this didn't generate errors before, and I can't find any info about this EditorStyleSet.h in the UE 5.1 release notes. But maybe it's just a newer compiler or something that is less forgiving.

@dustout
Copy link

dustout commented Feb 2, 2023

I'm cheering for you! I'll take a deeper look in the evening and see if I can figure it out as well, fingers crossed that one of us can solve this problem.

@getnamo
Copy link

getnamo commented Feb 2, 2023

This changelist may be helpful for updating Unreal.js to 5.1: getnamo/UnrealJs@3836ff2. Largely changed FEditorStyle to FAppStyle

and getnamo/UnrealJs@733c763 for re-enabling logging.

There are still some deprecation warnings on compile, but it does run.

@getnamo
Copy link

getnamo commented Feb 2, 2023

Made minor fixes and made a fork release (win64) for 5.1: https://github.com/getnamo/UnrealJs/releases/tag/v0.7.0

@Hannessa
Copy link
Author

Hannessa commented Feb 2, 2023

That's amazing. I just tested it, and it runs out of the box. Thanks so much for fixing this! This should really be merged into the original repo. Great job!

@dochigun-nc
Copy link
Collaborator

UE 5.1 supported version has been pushed.

@Johnly1986
Copy link

@dochigun-nc The new version can't run the example normally, and input "GWorld" in the JavaScript console prompts an undefined error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants