Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick report about translations #49

Open
natan-dias opened this issue May 20, 2023 · 0 comments
Open

Quick report about translations #49

natan-dias opened this issue May 20, 2023 · 0 comments

Comments

@natan-dias
Copy link
Contributor

In my fork I just removed some images, because Persian images were making difficult to just translate that. So, if you want to translate, just add a new section in textStrings file with your language TAG and change the last line to put your language TAG as the default language.

In my case, it was like that:
var textStrings = textStrings_PT_BR;

I don't think that change images with another language would be a good solution. i think the best case scenario would be duplicate the images with a new file name and create some conditional to load that image if your language is selected. For me, it doesn't make sense to have a new image on top of that with a language printed inside of it. But for now, I will not submit a new PR. I made the changes only on my personal forked repo and revert some changes, so the game is closer to the owner's game.

I hope this can be helpful.

Kind regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant