-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem creating the skeleton #8
Comments
Are you referring to the mesh contraction or the edge collapse? |
To the mesh contraction |
In general, the algorithm presented in the paper leaves a lot of details out which in turn left me to go with my best guess and "whatever works". Hence the disclaimer: my implementation might contain errors. That being said, the authors provide code with their paper (download link on this website) if you want to have a look.
I'm guessing this refers to the dimensions of the mesh not the number of vertices/faces? Yes, I found parameterisation of the algorithm to be finicky at times. In theory,
Not having seen any of your code (even if: I'm not very familiar with C++), I can't possibly tell you how to fix it. Off the top of my head, the only thing I can think of is that depending on how you produce the Laplacian operator, a degenerate face might give you infinite values. My solution to this has been to simply clamp those to very high values instead: https://github.com/schlegelp/skeletor/blob/09d55e1f63f44bc3f99ebbd968850b0a5c356d46/skeletor/utilities.py#L167 Other than that, I can only recommend stepping through the algorithm and do a side-by-side comparison between the results from the Python and your implementation. It's entirely possible that there is some under-the-hood Python magic that makes my code work but doesn't fly with C++. Anywho: keep me posted - if you find errors/improvements during your work, I'd be happy to hear them! |
Hi !
I'm currently implementing the exact same solution, but on C++ using LibIGL, and there's a couple of questions I have, if you can help me it would mean a lot
Thanks !
The text was updated successfully, but these errors were encountered: