Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore expanding Account JetStream Statistics for parity with prometheus-nats-exporter #179

Open
caleblloyd opened this issue Dec 26, 2023 · 2 comments
Assignees
Labels
proposal Enhancement idea or proposal

Comments

@caleblloyd
Copy link
Contributor

caleblloyd commented Dec 26, 2023

Explore expanding Account JetStream Statistics for parity with prometheus-nats-exporter:

https://github.com/nats-io/prometheus-nats-exporter/blob/f6cb9e62471baa3a74dd048ed320898ce7cd85d1/collector/jsz.go#L33-L57

One concern to evaluate: will adding statistics with labels at the Stream and Consumer level create a potentially high number of Time Series that could affect Prometheus due to high label cardinality - see this cloudflare blog post

@caleblloyd caleblloyd added the proposal Enhancement idea or proposal label Dec 26, 2023
@mtmk
Copy link
Contributor

mtmk commented Dec 14, 2024

@mtmk mtmk self-assigned this Dec 14, 2024
@mtmk
Copy link
Contributor

mtmk commented Dec 14, 2024

One concern to evaluate: will adding statistics with labels at the Stream and Consumer level create a potentially high number of Time Series that could affect Prometheus due to high label cardinality - see this cloudflare blog post

if this could create an issue for an existing deployment upgrading and creating problems with prometheus then I propose to introduce a couple of flags defaulting to off for stream and consumer stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Enhancement idea or proposal
Projects
None yet
Development

No branches or pull requests

2 participants