Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal plugin doesn't work consistently #435

Open
mlagerberg opened this issue Apr 20, 2015 · 3 comments
Open

Terminal plugin doesn't work consistently #435

mlagerberg opened this issue Apr 20, 2015 · 3 comments

Comments

@mlagerberg
Copy link

The terminal plugin works for the 'obvious' terminal commands, e.g. $ ls or $ nano, but not for other commands, applications or aliases that could be launched from the terminal.

For example, as an Android developer I have frequently run 'adb' in the terminal, however when I type $ adb in spotlight, Flashlight is nowhere to be seen (top result is the wiki page for Asian Development Bank). The same goes when I use run or execute instead.

@thomaspaulmann
Copy link

I am also interested in this feature!

@benjamin-weiss
Copy link

A quick look into the source code of the plugin reveals, that the plugin relies on whereis to verify if the command is valid or not. That is imho no good choice. It should either do not care at all if a command is valid and just check for $ (what I would like to see → I know what command I want to execute) or at least use which to check the validity of the command.

@benjamin-weiss
Copy link

Couldn't wait for someone else to fix it. 😏 So here is a PR (#523) with an implementation where the terminal plugin works as I want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants