Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses #3382 move-granules documentation #3383

Closed
wants to merge 1 commit into from
Closed

Addresses #3382 move-granules documentation #3383

wants to merge 1 commit into from

Conversation

mattp0
Copy link

@mattp0 mattp0 commented May 11, 2023

Summary: Summary of changes
Add clarity to how the bucket field needs to be configured
closes #3382
Update documentation for the corresponding files.

Changes

  • Detailed list or prose of changes
  • Update move-granules Readme.md to contain a clearer definition of bucket in task_config
  • Update move-granules index.js to contain a clearer doc string for bucket
  • Update move-granules config.json schema to be clearer how the field bucket should be configured.

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

@mattp0
feat: update moveGranules docs
9241e46 
Add clarity to how the `bucket`
field needs to be configured
@Jkovarik Jkovarik added User Contribution needs prioritization External review needs prioritized labels May 12, 2023
@Nnaga1 Nnaga1 mentioned this pull request Jul 6, 2023
Merged
4 tasks
@Nnaga1
Copy link
Contributor

Nnaga1 commented Jul 19, 2023 •
edited
Loading

hey @mattp0, I am going to close this, I included the changes you made in this PR: #3423 (along with an additional user PR), thanks for your contribution 🙌

@Nnaga1 Nnaga1 closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs prioritization External review needs prioritized User Contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MoveGranules documentation is incorrect for task config bucket
3 participants
@mattp0 @Nnaga1 @Jkovarik