Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoveGranules documentation is incorrect for task config bucket #3382

Open
mattp0 opened this issue May 11, 2023 · 1 comment
Open

MoveGranules documentation is incorrect for task config bucket #3382

mattp0 opened this issue May 11, 2023 · 1 comment

Comments

@mattp0
Copy link

mattp0 commented May 11, 2023

It describes requiring a bucket that contains a public and private key for CMR. But the code is using this bucket as the sourceBucket to pull the data from.
https://github.com/nasa/cumulus/blob/master/tasks/move-granules/schemas/config.json#L14
https://github.com/nasa/cumulus/blob/master/tasks/move-granules/README.md?plain=1#L15
https://github.com/nasa/cumulus/blob/master/tasks/move-granules/index.js#L244
https://github.com/nasa/cumulus/blob/master/tasks/move-granules/index.js#LL294C3-L294C3 #config.bucket being passed to moveFilesForAllGranules
https://github.com/nasa/cumulus/blob/master/tasks/move-granules/index.js#L214 # second param is for sourceBucket

Putting the wrong bucket in results in a non descriptive error:

{\"errorType\":\"TypeError\",\"errorMessage\":\"Function has non-object prototype 'undefined' in instanceof check\",\"trace\":[\"TypeError: Function has non-object prototype 'undefined' in instanceof check\",\"    at Function.[Symbol.hasInstance] (<anonymous>)\",\"    at Object.waitForObjectToExist (/var/task/webpack:/src/S3.ts:228:14)\",\"    at runNextTicks (internal/process/task_queues.js:60:5)\",\"    at listOnTimeout (internal/timers.js:526:9)\",\"    at processTimers (internal/timers.js:500:7)\",\"    at moveFileRequest (/var/task/webpack:/index.js:163:3)\",\"    at async Promise.all (index 0)\",\"    at /var/task/webpack:/index.js:222:24\",\"    at async Promise.all (index 0)\",\"    at moveFilesForAllGranules (/var/task/webpack:/index.js:234:3)\"]}
@jjmccoy
Copy link
Member

jjmccoy commented Jun 16, 2023

Thanks @mattp0. We have submitted a PR for this update: https://bugs.earthdata.nasa.gov/browse/CUMULUS-3345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants